Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khKWz-0006zl-CQ for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Nov 2020 22:41:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1khKWx-0005Ao-SR for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Nov 2020 22:41:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khKWx-0005Ah-LV for pgsql-hackers@lists.postgresql.org; Mon, 23 Nov 2020 22:41:55 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khKWr-0002oG-4O for pgsql-hackers@lists.postgresql.org; Mon, 23 Nov 2020 22:41:54 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 664FA5C017D; Mon, 23 Nov 2020 17:41:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 23 Nov 2020 17:41:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=y9NWwh7Wo0FBDt4TV YUrFp2F+O1EE6mnhTlJTRVl4P8=; b=iZ95tpwFhUSsPJW4V6DPCZ6a7xGcZZiJa 0D8Jj5uVvaV9gqMPoAQO4vRzR/0I5j8eSvRhXRn4fcIKiGy07gXaeOxRiUe5L4pb LcneKjmnpQENlgfKSNiFqDRzMqLiFjm/XgchbYtyQ4GsKVlMkVX6Rd589CG/kaxF MhWKOSRimmgUPmF/mwAR/ijdHFXKV3lb6haRQrcvrFPkxSscq72kfsINVDQhFqQl 8Ses+TTbafHa/3gSc7hBa1ru611rnqOxLu/qxI3ElmEGJ1JrqD5mmUQF72KAVbjB twq0Jvkrb0dhpmE0mZg9Dr8KHJBd/fcloNEgxATHxOWtkQnW9hSRQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegjedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggujggfsehttdertddtredvnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeevgfelveegueejgefhgeetgefhgeehieefheehleetteei udeiiefhgffgheffteenucfkphepudeltddrleehrddukedrjeelnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhv hhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.18.79]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B0533280064; Mon, 23 Nov 2020 17:41:47 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id AC41E2A1006; Mon, 23 Nov 2020 19:41:45 -0300 (-03) Date: Mon, 23 Nov 2020 19:41:45 -0300 From: Alvaro Herrera To: Tom Lane Cc: Michael Paquier , Andres Freund , Dmitry Dolgov <9erthalion6@gmail.com>, James Coleman , Pg Hackers Subject: Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait) Message-ID: <20201123224145.GA1405@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123223854.GA1110@alvherre.pgsql> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Nov-23, Alvaro Herrera wrote: > On 2020-Nov-23, Tom Lane wrote: > > > Here's a draft patch. > > Here's another of my own. Outside of elog.c it seems identical. Your version has the advantage that errstart() doesn't get a new function call. I'm +1 for going with that ... we could avoid the duplicate code with some additional contortions but this changes so rarely that it's probably not worth the trouble.