Date: Tue, 24 Nov 2020 11:53:22 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Fabien COELHO <coelho@cri.ensmp.fr>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Steele <david@pgmasters.net>, pgsql-hackers@postgresql.org,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and
 pg_ls_*)
Message-ID: <20201124165322.GS16415@tamriel.snowman.net>
References: <20200526021003.GW4472@telsasoft.com>
 <alpine.DEB.2.22.394.2006070908120.32228@pseudo>
 <20200622015325.GG17995@telsasoft.com>
 <20200715030839.GX23581@telsasoft.com>
 <20200718201532.GV23581@telsasoft.com>
 <20200908195126.GB18552@telsasoft.com>
 <20201028193402.GA28528@telsasoft.com>
 <129225.1606166058@sss.pgh.pa.us>
 <20201123230031.GR16415@tamriel.snowman.net>
 <198112.1606172779@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bSKfi/U8hY2tIFFx"
Content-Disposition: inline
In-Reply-To: <198112.1606172779@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--bSKfi/U8hY2tIFFx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> >> I took a quick look through this.  This is just MHO, of course:
> >>=20
> >> * I don't think it's okay to change the existing signatures of
> >> pg_ls_logdir() et al.
>=20
> > I disagree that we need to stress over this- we pretty routinely change
> > the signature of various catalogs and functions and anyone using these
> > is already of the understanding that we are free to make such changes
> > between major versions.
>=20
> Well, like I said, just MHO.  Anybody else want to weigh in?
>=20
> I'm mostly concerned about removing the isdir output of pg_stat_file().
> Maybe we could compromise to the extent of keeping that, allowing it
> to be partially duplicative of a file-type-code output column.

I don't have any particular issue with keeping isdir as a convenience
column.  I agree it'll now be a bit duplicative but that seems alright.

Thanks,

Stephen

--bSKfi/U8hY2tIFFx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJfvTqBAAoJEO1sijiDR2RVMJQQAK/47OT1E8NluiDhtPFS1vUH
61oRU7KHEXvnaYBjuwwTT51JrYhocnWHDfgbDHXVOCMqtE4UnQoVBVhoqClxk9fu
lMuBfA+IS/3eMG05pjlWB9uuv7adJJjVDBueeJ9dxmN20AW6XqXzjlffWnGkVZfR
3hKsDcrFg1IMtf2VljsmDzgeSSiu/VKmD+We9hX2K35ZZlOqYmIQmhIzMxj1xkQz
GNPygPpDj9O9BH4KSc20d2Fx9CS0+akuql2uYfLPJspSS6CiJGez3AEe7OGo+DEy
rg021Xa2gU3kIUkQnvk8vK3Y95i5NEF/1G/fEqy/s5dpfUVspEsWka+IMGU3GCzy
14TWMuPNGvFvmtk9a2mhwa1w/oAW/NWOw6HIljLkbGUP+aKXxUFjosnHFlvHoSkK
BCsX9mksy9tRcVmJeeKozl48AYgrRFY3GP5BUI59NTmSr8OLQktpoAyUwO3e6Bry
em8hqnbv4JZfjFEIEx/yGjLEFae564MCXg004NjRzm+2bYpsMBXpvGh9AnbaA9/z
7ziDbIW8Ph3UxTFewZlqEZoP68cTCQLAqvOCq3GbiPSW0UKnc6Zc7M/Kcv61eQUh
6DLVFNkiXelWYix9IE4fxYo4ZlI71Sn8wtfiwNNorHxwTdMVfuyzSwy4iwEY6uPO
R055VMEVFR20bbLT37wc
=QgyA
-----END PGP SIGNATURE-----

--bSKfi/U8hY2tIFFx--