Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ki65B-0006DZ-OV
	for pgsql-hackers@arkaria.postgresql.org; Thu, 26 Nov 2020 01:28:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ki65A-0002vc-Jo
	for pgsql-hackers@arkaria.postgresql.org; Thu, 26 Nov 2020 01:28:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <movead.li@highgo.ca>)
	id 1ki65A-0002vU-9w
	for pgsql-hackers@lists.postgresql.org; Thu, 26 Nov 2020 01:28:24 +0000
Received: from sender4-op-o17.zoho.com ([136.143.188.17])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <movead.li@highgo.ca>)
	id 1ki657-0004P4-LZ
	for pgsql-hackers@lists.postgresql.org; Thu, 26 Nov 2020 01:28:23 +0000
ARC-Seal: i=1; a=rsa-sha256; t=1606354092; cv=none;
	d=zohomail.com; s=zohoarc;
	b=oC9BY+PLyTcm3Y5RM6wU2HZnp59OC+Gw0XG/qH64x4lsb+oSmgpYPYsJrksn0Yfxod6xnsydATguCDEwR9iuCCWS5qxjQT3zOcdGGSz16Lvp+ZS6z4QQXJVAIoJBYBWL6oTePRFv3iZHRGoFe1y0UruSuxjT76ZtNNC677l2Vl0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc;
	t=1606354092;
 h=Content-Type:Cc:Date:From:MIME-Version:Message-ID:References:Subject:To;
	bh=z6rUIyqYmc+ydx2n6eBZUkpkzeVteTsRAAt4AC3CKW8=;
	b=awopObOeAouTB32mhZ39vRC6YzbW8R+oI0AH731c/77PcihCRPO8IjQNgmjaritBDmcbtqzQ+Y4hq4p2Eijnf6gOp1Q+IILgadpq32bXFKftTipC/tMp41rX6NQpVI9ZAZxTSpXXyhGut+8FUinjJZaftfxrVYsELqnOiKeoszo=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=highgo.ca;
	spf=pass  smtp.mailfrom=movead.li@highgo.ca;
	dmarc=pass header.from=<movead.li@highgo.ca>
 header.from=<movead.li@highgo.ca>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1606354092;
	s=zoho; d=highgo.ca; i=movead.li@highgo.ca;
	h=Date:From:To:Cc:Subject:References:Mime-Version:Message-ID:Content-Type;
	bh=z6rUIyqYmc+ydx2n6eBZUkpkzeVteTsRAAt4AC3CKW8=;
	b=YFSRJ5SdboeQrOHerHG/zRhinUej5YTeX3mU45zIR6023lvQrV290y0i+ZU77QfN
	AtiFmLSnMtpkmgfNsNcFVceYK2BVYljf4RZB5s4U0cjI56secvShKzTz/DKhHeWdcAA
	ll3DwOYSIh+dXGXS/mdXgTwOPiCx97S1HIpJ9r5c=
Received: from lchch (124.133.18.218 [124.133.18.218]) by mx.zohomail.com
	with SMTPS id 1606354089889770.3853184944438;
 Wed, 25 Nov 2020 17:28:09 -0800 (PST)
Date: Thu, 26 Nov 2020 09:28:06 +0800
From: "movead.li@highgo.ca" <movead.li@highgo.ca>
To: "Etsuro Fujita" <etsuro.fujita@gmail.com>,
	Horiguchi <horikyota.ntt@gmail.com>
Cc: "Justin Pryzby" <pryzby@telsasoft.com>,
	"Andrey V. Lepikhov" <a.lepikhov@postgrespro.ru>,
	"Ahsan Hadi" <ahsan.hadi@gmail.com>,
	pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Asynchronous Append on postgres_fdw nodes.
References: 
 <CAPmGK153oorYtTpW_-aZrjH-iecHbykX7qbxX_5630ZK8nqVHg@mail.gmail.com>,
	<20201002.153925.2111528346612886434.horikyota.ntt@gmail.com>,
	<CAPmGK16YXCADSwsFLSxqTBBLbt3E_=iigKTtjS=dqu+8K8DWCw@mail.gmail.com>,
	<20201005.132959.1424481454550541470.horikyota.ntt@gmail.com>,
	<CAPmGK17Ura3NUXYP98W4jz0VT9BAyVFhNRqZyFV-_mqFDB0j7Q@mail.gmail.com>,
	<CAPmGK14xrGe+Xks7+fVLBoUUbKwcDkT9km1oFXhdY+FFhbMjUg@mail.gmail.com>
X-Priority: 3
X-GUID: 12387B4D-2122-448D-A5F7-B4D00C4AA8FF
X-Has-Attach: no
X-Mailer: Foxmail 7.2.16.188[cn]
Mime-Version: 1.0
Message-ID: <2020112609280420453319@highgo.ca>
Content-Type: multipart/alternative;
	boundary="----=_001_NextPart025666770572_=----"
X-ZohoMailClient: External
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

This is a multi-part message in MIME format.

------=_001_NextPart025666770572_=----
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: base64

DQpJIHRlc3QgdGhlIHBhdGNoIGFuZCBvY2N1ciBzZXZlcmFsIGlzc3VlcyBhcyBibG93Og0KDQpJ
c3N1ZSBvbmU6DQpHZXQgYSBBc3NlcnQgZXJyb3IgYXQgJ0Fzc2VydChibXNfaXNfbWVtYmVyKGks
IG5vZGUtPmFzX25lZWRyZXF1ZXN0KSk7JyBpbg0KRXhlY0FwcGVuZEFzeW5jUmVxdWVzdCgpIGZ1
bmN0aW9uIHdoZW4gSSB1c2UgbW9yZSB0aGFuIHR3byBmb3JlaWduIHRhYmxlDQpvbiBkaWZmZXJl
bnQgZm9yZWlnbiBzZXJ2ZXIuDQoNCkkgcmVzZWFyY2ggdGhlIGNvZGUgYW5kIGRvIHN1Y2ggY2hh
bmdlIHRoZW4gdGhlIEFzc2VydCBwcm9ibG9tIGRpc2FwcGVhci4NCg0KQEAgLTEwMDQsNiArMTAw
NCw3IEBAIEV4ZWNBcHBlbmRBc3luY1Jlc3BvbnNlKEFzeW5jUmVxdWVzdCAqYXJlcSkgYm1zX2Rl
bF9tZW1iZXIobm9kZS0+YXNfbmVlZHJlcXVlc3QsIGFyZXEtPnJlcXVlc3RfaW5kZXgpOyBub2Rl
LT5hc19hc3luY3BlbmRpbmcgPSBibXNfYWRkX21lbWJlcihub2RlLT5hc19hc3luY3BlbmRpbmcs
IGFyZXEtPnJlcXVlc3RfaW5kZXgpOyArIG5vZGUtPmFzX2xhc3Rhc3luY3BsYW4gPSBJTlZBTElE
X1NVQlBMQU5fSU5ERVg7IHJldHVybiBmYWxzZTsgfQ0KDQpJc3N1ZSB0d286DQpUaGVuIEkgdGVz
dCBhbmQgZmluZCBpZiBJIGhhdmUgc3luYyBzdWJwbGFuIGFuZCBhc3luYyBzdW5icGxhbiwgaXQg
d2lsbCBydW4gb3Zlcg0KdGhlIHN5bmMgc3VicGxhbiB0aGVuIHRoZSBhc3luYyB0dXJuLCBJIGRv
IG5vdCBrbm93IGlmIGl0IGlzIGludGVudC4NCg0KSXNzdWUgdGhyZWU6DQpBZnRlciBjb2RlIGNo
YW5nZSBtZW50aW9uZWQgaW4gdGhlIElzc3VlIG9uZSwgSSBjYW4gbm90IGdldCBwZXJmb3JtYW5j
ZSBpbXByb3ZlbWVudC4NCkkgcXVlcnkgb24gcGFydGl0aW9uZWQgdGFibGUgYW5kIGFsbCBzdWIt
cGFydGl0aW9uIHRoZSB0aW1lIHNwZW50IG9uIHBhcnRpdGlvbmVkIHRhYmxlDQphbHdheXMgc2Ft
ZSBhcyB0aGUgc3VtIG9mIGFsbCBzdWItcGFydGl0aW9uLg0KDQpTb3JyeSBpZiBJIGhhdmUgc29t
ZXRoaW5nIHdyb25nIHdoZW4gdGVzdCB0aGUgcGF0Y2guDQoNCg0KDQpSZWdhcmRzLA0KSGlnaGdv
IFNvZnR3YXJlIChDYW5hZGEvQ2hpbmEvUGFraXN0YW4pIA0KVVJMIDogd3d3LmhpZ2hnby5jYQ0K

------=_001_NextPart025666770572_=----
Content-Type: text/html;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charse=
t=3DUTF-8"><style>body { line-height: 1.5; }blockquote { margin-top: 0px; =
margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; font-fa=
mily: 'Microsoft YaHei UI'; color: rgb(0, 0, 0); line-height: 1.5; }</styl=
e></head><body>=0A<div><span></span><br></div><div>I test the patch and oc=
cur several issues as blow:</div><div><br></div><div>Issue one:</div><div>=
Get a Assert error at '<span style=3D"line-height: 22px; white-space: pre;=
">Assert</span><span style=3D"line-height: 22px; white-space: pre;">(bms_i=
s_member(i,&nbsp;node-&gt;as_needrequest));</span><span style=3D"line-heig=
ht: 1.5;">'&nbsp;</span><span style=3D"font-size: 10.5pt; line-height: 1.5=
; background-color: transparent;">in</span></div><div><span style=3D"font-=
size: 10.5pt; line-height: 22px; white-space: pre; background-color: trans=
parent;">ExecAppendAsyncRequest() function when I use more than two foreig=
n table</span></div><div><span style=3D"font-size: 10.5pt; line-height: 22=
px; white-space: pre; background-color: transparent;">on different foreign=
 </span><span style=3D"line-height: 22px; white-space: pre; font-size: 10.=
5pt; background-color: transparent;">server.</span></div><div><span style=
=3D"line-height: 22px; white-space: pre; font-size: 10.5pt; background-col=
or: transparent;"><br></span></div><div><span style=3D"line-height: 22px; =
white-space: pre; font-size: 10.5pt; background-color: transparent;">I res=
earch the code and do such change then the Assert problom disappear.</span=
></div><div><span style=3D"line-height: 22px; white-space: pre;"><br></spa=
n></div><div><span style=3D"line-height: 22px; white-space: pre;">@@ -1004=
,6 +1004,7 @@ ExecAppendAsyncResponse(AsyncRequest *areq)=0A              =
  bms_del_member(node-&gt;as_needrequest, areq-&gt;request_index);=0A     =
           node-&gt;as_asyncpending =3D bms_add_member(node-&gt;as_asyncpe=
nding,=0A                                                                 =
                          areq-&gt;request_index);=0A+               node-=
&gt;as_lastasyncplan =3D INVALID_SUBPLAN_INDEX;=0A                return f=
alse;=0A        }</span></div><div><span style=3D"line-height: 22px; white=
-space: pre;"><br></span></div><div><span style=3D"line-height: 22px; whit=
e-space: pre;">Issue two:</span></div><div><span style=3D"line-height: 22p=
x; white-space: pre;">Then I test and find if I have sync subplan and asyn=
c sunbplan, it will run over</span></div><div><span style=3D"line-height: =
22px; white-space: pre;">the sync subplan then </span><span style=3D"line-=
height: 22px; white-space: pre; font-size: 10.5pt; background-color: trans=
parent;">the async turn, I do not know if it is intent.</span></div><div><=
span style=3D"line-height: 22px; white-space: pre;"><br></span></div><div>=
<span style=3D"line-height: 22px; white-space: pre;">Issue three:</span></=
div><div><span style=3D"line-height: 22px; white-space: pre;">After code c=
hange mentioned in the Issue one, I can not get performance improvement.</=
span></div><div><span style=3D"line-height: 22px; white-space: pre;">I que=
ry on </span><span style=3D"line-height: 22px; white-space: pre; font-size=
: 10.5pt; background-color: transparent;">partitioned table and all sub-pa=
rtition the time spent on partitioned table</span></div><div><span style=
=3D"line-height: 22px; white-space: pre; font-size: 10.5pt; background-col=
or: transparent;">always same as the sum  </span><span style=3D"line-heigh=
t: 22px; white-space: pre; font-size: 10.5pt; background-color: transparen=
t;">of all sub-partition.</span></div><div><span style=3D"line-height: 22p=
x; white-space: pre;"><br></span></div><div><span style=3D"line-height: 22=
px; white-space: pre;">Sorry if I have something wrong when test the patch=
.</span></div>=0A<div><br></div><hr style=3D"width: 210px; height: 1px;" c=
olor=3D"#b5c4df" size=3D"1" align=3D"left">=0A<div><span><div style=3D"MAR=
GIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt"><span style=3D"color: rg=
b(13, 10, 11); font-family: monospace, monospace; font-size: 10.7333px; fo=
nt-variant-ligatures: normal; orphans: 2; white-space: pre-wrap; widows: 2=
;">Regards,</span></div><div style=3D"MARGIN: 10px; FONT-FAMILY: verdana; =
FONT-SIZE: 10pt"><span style=3D"color: rgb(13, 10, 11); font-family: monos=
pace, monospace; font-size: 10.7333px; font-variant-ligatures: normal; orp=
hans: 2; white-space: pre-wrap; widows: 2;">Highgo Software (Canada/China/=
Pakistan) </span><br style=3D"box-sizing: border-box; color: rgb(13, 10, 1=
1); font-family: monospace, monospace; font-size: 10.7333px; font-variant-=
ligatures: normal; orphans: 2; white-space: pre-wrap; widows: 2;"><span st=
yle=3D"color: rgb(13, 10, 11); font-family: monospace, monospace; font-siz=
e: 10.7333px; font-variant-ligatures: normal; orphans: 2; white-space: pre=
-wrap; widows: 2;">URL : </span><a href=3D"http://www.highgo.ca/" rel=3D"n=
ofollow" style=3D"box-sizing: border-box; color: rgb(132, 0, 50); text-dec=
oration: none; font-weight: 600; transition: color 0.2s ease-in-out 0s; fo=
nt-family: monospace, monospace; font-size: 10.7333px; font-variant-ligatu=
res: normal; orphans: 2; white-space: pre-wrap; widows: 2;">www.highgo.ca<=
/a><br></div></span></div><blockquote style=3D"margin-Top: 0px; margin-Bot=
tom: 0px; margin-Left: 0.5em; margin-Right: inherit"><div>=0A</div></block=
quote>=0A</body></html>
------=_001_NextPart025666770572_=------