Date: Mon, 30 Nov 2020 23:43:08 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexey Kondratov <a.kondratov@postgrespro.ru>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Steve Singer <steve@ssinger.info>,
	pgsql-hackers@lists.postgresql.org,
	Robert Haas <robertmhaas@gmail.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Jose Luis Tallon <jltallon@adv-solutions.net>
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on
 the fly
Message-ID: <20201201054308.GC24052@telsasoft.com>
References: <20200909000238.GA1563@alvherre.pgsql>
 <20200909001757.GD18552@telsasoft.com>
 <20200909122200.GA2743@paquier.xyz>
 <20200909153629.GG18552@telsasoft.com>
 <a9d64111ffe72f51069d50e90d5bf029@postgrespro.ru>
 <20201031183611.GA22691@telsasoft.com>
 <20201124153123.GO24052@telsasoft.com>
 <X8TYkH2cJHzqFDGM@paquier.xyz>
 <bfc3903c0e30ef4349ec5cfee625d8d5@postgrespro.ru>
 <X8Wun1FBVgcqb6Fb@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <X8Wun1FBVgcqb6Fb@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Dec 01, 2020 at 11:46:55AM +0900, Michael Paquier wrote:
> On Mon, Nov 30, 2020 at 05:12:42PM +0300, Alexey Kondratov wrote:
> > Thanks. I have rebased the remaining patches on top of 873ea9ee to use
> > 'utility_option_list' instead of 'common_option_list'.
> 
> Thanks, that helps a lot.  I have gone through 0002, and tweaked it as
> the attached (note that this patch is also interesting for another
> thing in development: backend-side reindex filtering of
> collation-sensitive indexes).  Does that look right to you?

I eyeballed the patch and rebased the rest of the series on top if it to play
with.  Looks fine - thanks.

FYI, the commit messages have the proper "author" for attribution.  I proposed
and implemented the grammar changes in 0002, and implemented INDEX_TABLESPACE,
but I'm a reviewer for the main patches.

-- 
Justin