Date: Thu, 10 Dec 2020 22:02:10 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Bossart, Nathan" <bossartn@amazon.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"k.jamison@fujitsu.com" <k.jamison@fujitsu.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: please update ps display for recovery checkpoint
Message-ID: <20201211040210.GZ24052@telsasoft.com>
References: <20200919160031.GC30557@telsasoft.com>
 <20201002072814.GE1464@paquier.xyz>
 <20201002091354.GH8476@telsasoft.com>
 <9A1B9D98-4576-438A-943F-0AFB05946C7C@amazon.com>
 <20201203215809.GS24052@telsasoft.com>
 <1A9049D3-44B9-4504-AC18-4BE42F69E8AB@amazon.com>
 <549f04f1-6362-b599-c5e6-87330e36f03d@oss.nttdata.com>
 <X9Brc31Jj5cemRUw@paquier.xyz>
 <B8C46DD1-557F-4D20-97DD-DBC16772457F@amazon.com>
 <X9Ltbgcqy18Xvizq@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <X9Ltbgcqy18Xvizq@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Isn't the sense of "reset" inverted ?

I think maybe you mean to do set_ps_display(""); in the "if reset".

On Fri, Dec 11, 2020 at 12:54:22PM +0900, Michael Paquier wrote:
> +update_checkpoint_display(int flags, bool restartpoint, bool reset)
> +{
> +	if (reset)
> +	{
> +		char activitymsg[128];
> +
> +		snprintf(activitymsg, sizeof(activitymsg), "performing %s%s%s",
> +				 (flags & CHECKPOINT_END_OF_RECOVERY) ? "end-of-recovery " : "",
> +				 (flags & CHECKPOINT_IS_SHUTDOWN) ? "shutdown " : "",
> +				 restartpoint ? "restartpoint" : "checkpoint");
> +		set_ps_display(activitymsg);
> +	}
> +	else
> +		set_ps_display("");
> +}
> +
> +
>  /*
>   * Perform a checkpoint --- either during shutdown, or on-the-fly
>   *
> @@ -8905,6 +8937,9 @@ CreateCheckPoint(int flags)
>  	if (log_checkpoints)
>  		LogCheckpointStart(flags, false);
>  
> +	/* Update the process title */
> +	update_checkpoint_display(flags, false, false);
> +
>  	TRACE_POSTGRESQL_CHECKPOINT_START(flags);
>  
>  	/*
> @@ -9120,6 +9155,9 @@ CreateCheckPoint(int flags)
>  	/* Real work is done, but log and update stats before releasing lock. */
>  	LogCheckpointEnd(false);
>  
> +	/* Reset the process title */
> +	update_checkpoint_display(flags, false, true);
> +
>  	TRACE_POSTGRESQL_CHECKPOINT_DONE(CheckpointStats.ckpt_bufs_written,
>  									 NBuffers,
>  									 CheckpointStats.ckpt_segs_added,
> @@ -9374,6 +9412,9 @@ CreateRestartPoint(int flags)
>  	if (log_checkpoints)
>  		LogCheckpointStart(flags, true);
>  
> +	/* Update the process title */
> +	update_checkpoint_display(flags, true, false);
> +
>  	CheckPointGuts(lastCheckPoint.redo, flags);
>  
>  	/*
> @@ -9492,6 +9533,9 @@ CreateRestartPoint(int flags)
>  	/* Real work is done, but log and update before releasing lock. */
>  	LogCheckpointEnd(true);
>  
> +	/* Reset the process title */
> +	update_checkpoint_display(flags, true, true);
> +
>  	xtime = GetLatestXTime();
>  	ereport((log_checkpoints ? LOG : DEBUG2),
>  			(errmsg("recovery restart point at %X/%X",