Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koeRU-00029X-UZ for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Dec 2020 03:22:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1koeRT-0000pw-Hx for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Dec 2020 03:22:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koeRT-0000po-7t for pgsql-hackers@lists.postgresql.org; Mon, 14 Dec 2020 03:22:31 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1koeRQ-0003R6-85 for pgsql-hackers@postgresql.org; Mon, 14 Dec 2020 03:22:30 +0000 Received: by mail-il1-x131.google.com with SMTP id x15so14562078ilq.1 for ; Sun, 13 Dec 2020 19:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V8yl2z5rmIzHkPfRThZoz83eQpexhckY5ToXTuXiE9k=; b=BBloUNPaX8wrcBbGhGFH1MxUUIzwKjHKm6dPFnZ7EphtMNJQowS1i47kFSWzrrxRy8 +wnwutSEymgxl7zkG6m642SDw5MES4iLYeiuhPBO8km3IoWRzik/HDJBl0h3za9SYjnP T4ujJKy8xUUBQ25STLxZVYUKzomM51g70YRSMqGH4ZUQZXDu/vfP6oO1CIzeAOaNMIVh mhPWBs3VXdVKHIy0YBqHOt0CVRE9ftdl5DQcjt72JQOs1H5+v28ge8Jp+epVLkZW+gZd qrFwH2rzwIYwFb5s6Yvm8kMoFabKnmVEKfllHuQIKssYOtvzqprVh1jhJTY5qdCzcspp 0fqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V8yl2z5rmIzHkPfRThZoz83eQpexhckY5ToXTuXiE9k=; b=Ebrbf8pvah4e9RLcaKKdSsVuxAs793rNIHN1AFQmjKWbC4+ZXbgcoug7uF2T8AP9FH l3IcIh9iLbyO7IG3SZ9azy92zsfu+KrPWpBHE6hhd71qC6igRGmlxZUctMspU0nUVN5N EwESWsra2ME4236T7nrpa06uxObYYp7mhA46XuBeWSMlcSkhDiLEM21ww/pWVHBGPdnF VA8OiW/3wW0fxLWFzwUu6MEKkM2kQHhP0YkDfYJTskoa8mEfkSEN8WsxYt56v4IZoWVp A0oJvSjg9XBF6lbMbIZun/23umzkrHGUTFYnXq/bdU34wY4BLj22sT/ltI5cUWX3VerM x5MA== X-Gm-Message-State: AOAM5337YeYtBITLjwgT7DCaCLf7mrKUe5P+DQPi1amesSqJZYvUXxvv Q13EDBxT1fO4xzHVI00CB+qoSQ== X-Google-Smtp-Source: ABdhPJyKe3q+Dh9g4RR4JIZr0pnLbcXUXTjwdv6eDzLDg1x8xgbmxp7ZqewiuaItBOTSFjrnZxjPEA== X-Received: by 2002:a92:9806:: with SMTP id l6mr35052680ili.304.1607916146246; Sun, 13 Dec 2020 19:22:26 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id p13sm8663361iod.54.2020.12.13.19.22.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Dec 2020 19:22:25 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id B0570800747; Sun, 13 Dec 2020 21:22:24 -0600 (CST) Date: Sun, 13 Dec 2020 21:22:24 -0600 From: Justin Pryzby To: Michael Paquier Cc: "Bossart, Nathan" , Fujii Masao , "k.jamison@fujitsu.com" , Thomas Munro , pgsql-hackers@postgresql.org Subject: Re: please update ps display for recovery checkpoint Message-ID: <20201214032224.GA30237@telsasoft.com> References: <549f04f1-6362-b599-c5e6-87330e36f03d@oss.nttdata.com> <20201211040210.GZ24052@telsasoft.com> <59A309AA-87C4-457E-A9D4-922BC5A418BA@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Mon, Dec 14, 2020 at 12:01:33PM +0900, Michael Paquier wrote: > On Sat, Dec 12, 2020 at 12:41:25AM +0000, Bossart, Nathan wrote: > > On 12/11/20, 4:00 PM, "Michael Paquier" wrote: > >> My counter-proposal is like the attached, with the set/reset part not > >> reversed this time, and the code indented :p > > > > Haha. LGTM. > > Thanks. I have applied this one, then. Thank you. I'm not sure, but we could consider backpatching something to clear the "recovering NNN" that's currently displayed during checkpoint, even though recovery of NNN has already completed. Possibly just calling set_ps_display(""); after "Real work is done". -- Justin