Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpC50-0006UV-Rw for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Dec 2020 15:17:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kpC4z-0004PP-5m for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Dec 2020 15:17:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpC4y-0004PH-VS for pgsql-hackers@lists.postgresql.org; Tue, 15 Dec 2020 15:17:32 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpC4w-0003iW-Pt for pgsql-hackers@postgresql.org; Tue, 15 Dec 2020 15:17:31 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1kpC4u-0006N6-Qq; Tue, 15 Dec 2020 10:17:28 -0500 Date: Tue, 15 Dec 2020 10:17:28 -0500 From: Bruce Momjian To: Michael Paquier Cc: PostgreSQL-development , Masahiko Sawada Subject: Re: Proposed patch for key managment Message-ID: <20201215151728.GD14596@momjian.us> References: <20201202213814.GG20285@momjian.us> <20201214230615.GA14596@momjian.us> <20201215031902.GB14596@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Dec 15, 2020 at 02:20:33PM +0900, Michael Paquier wrote: > > Uh, I got this code from pg_resetwal.c, which does something similar to > > pg_altercpass. > > Yeah, that's actually the part where it is a bad idea to just copy > this pattern. pg_resetwal should not do that in the long term in my > opinion, but nobody has come to clean up this stuff. (- -;) Glad you asked about this. It turns out pg_altercpass works fine with postgres_fe.h, so I will now use that. pg_resetwal still can't use it though. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee