Date: Thu, 17 Dec 2020 11:39:55 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bruce Momjian <bruce@momjian.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Subject: Re: Proposed patch for key managment
Message-ID: <20201217163954.GY16415@tamriel.snowman.net>
References: <20201202213814.GG20285@momjian.us>
 <20201214230615.GA14596@momjian.us>
 <X9gL7bD9idE2hoFt@paquier.xyz>
 <20201215031902.GB14596@momjian.us>
 <X9hHoQcZ11pBtgnz@paquier.xyz>
 <20201215210212.GG14596@momjian.us>
 <X9lhi1ht04I+v/rV@paquier.xyz>
 <20201216220412.GB4527@momjian.us>
 <X9qXuLekePLRYrB2@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="grPVVRSFoixyb5v7"
Content-Disposition: inline
In-Reply-To: <X9qXuLekePLRYrB2@paquier.xyz>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--grPVVRSFoixyb5v7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Michael Paquier (michael@paquier.xyz) wrote:
> On Wed, Dec 16, 2020 at 05:04:12PM -0500, Bruce Momjian wrote:
> >> fallback implementation.  Finally, pgcrypto is not touched, but we
> >=20
> > I have a fallback implemention --- it fails?  ;-)  Did you want me to
> > include an AES implementation?
>=20
> No idea about this one yet.  There are no direct users of AES except
> pgcrypto in core.  One thing that would be good IMO is to properly
> split the patch of this thread into individual parts that could be
> reviewed separately using for example "git format-patch" to generate
> patch series.  What's presented is a mixed bag, so that's harder to
> look at it and consider how this stuff should work, and if there are
> pieces that should be designed better or not.

I don't think there's any need for us to implement a fallback
implementation of AES.  I'm not entirely sure we need it for hashes
but since we've already got it...

Thanks,

Stephen

--grPVVRSFoixyb5v7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJf24naAAoJEO1sijiDR2RVW1cP/1MjRGZFzpBuLSmTWu+iMVYb
iVciSqfFoFviWSpznfqr+/iKkFDawOrpe9cKMhb6gCnbWZMubMAbBp4LhiC3g8fN
HFfpoeE+Pr2F0p9Zdz0yGG9bGURjzJyGs3WSLnWtpB49VIa3QwGORTO6so1mwUCI
VwGFT0EX8XENLTAqVZ65ZxJvmvfluCmSLWIsBhisTUtsJsLSInFJZijutPVjS60x
tEcflcMufZCmqVzPjKcT0DC9ECHybDaEC/qT6y4Z6Zuv9hRRJmT3Hr+9nwwnr4E/
aVJEj3D7nsfqXyhu3TOxFCXYaq72LwZqUmaq9YRlzXZXt4A65upkDT9zOAsnqFgR
uc5za8BkWW/AneSn86bGiuRJdgdMxEqaWWizsoVJzutOXDrtqSXvIUsdKkEMurHH
j68wUdPRbA9bhYv9XsA1BdIV/bnTrvGk5bHyA8psKB/K0ULKjgbXaw33P7JuWhsT
r5rjfSzT2k7o3CxImvY5QlQHdhjU7v7vHVuHBwIzaepqCpPX7sXK17EDb0WaD1KS
zA88X386TRurDuzRoU2zU1ZQaXyCGqwImiZONR3QLXqplzd2yGtzVd11fOhOc1/h
Dcxbf0Ft078cv4cA1D2al4va8lLjaMBmpVfmsBYKwgFOCLyIq8/Y9g2WvCEAYqaF
8HxWutiuq0Odk94HwZj2
=Oup0
-----END PGP SIGNATURE-----

--grPVVRSFoixyb5v7--