Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuTGt-0002Nw-Cn for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Dec 2020 04:39:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kuTGs-0002UF-Bj for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Dec 2020 04:39:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuTGs-0002U8-12 for pgsql-hackers@lists.postgresql.org; Wed, 30 Dec 2020 04:39:38 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kuTGp-00083X-7l for pgsql-hackers@postgresql.org; Wed, 30 Dec 2020 04:39:37 +0000 Received: by mail-il1-x130.google.com with SMTP id v3so13898612ilo.5 for ; Tue, 29 Dec 2020 20:39:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LHYthS9qFXR1csAo2vRqYicv41/DHJj7unYHi/70uFU=; b=uM7xcUlq1sy57j+MA5fQ334UtRwVoI8+EgoEluTlvWHfusZeKLkh4MfCcOeqk8pnuv Q+WL3IBF4cVQDnk/GZ/AGEzTaxtN06hvsHXaN1rc58gs03goxg1PTzwwJWXed5kyeRlX u0IhA4e3LWe0xxlzSzdagCekVry8ai7drVTZagnE0ipi+GciQ7kfbJJyLpnEgv0AfWpn nS+/9KJWvHAxm3b87Xzz9+Jj6U45HLdhwuj2ZDBumrVCeGWr5G0TwwzliL68ilUo83iI kzPkffu24UAfHs5T/95gcgZIXiWdJlZxZNUBevhsBev9BEtuJJW5is4GMjd+A8TMKEpH LIOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=LHYthS9qFXR1csAo2vRqYicv41/DHJj7unYHi/70uFU=; b=ltcO+n0f2HxvtLf6V4XvuR+Go/ZTYRQC6CIJV+8O5HRU3MzpZYR1HNIDpZhoj1G8oT CtI7bQtTDLwY30H6AzxvNNFKDEJ18TXiVYm9Tf9velme8Ur8w3ZkDKd74lMvGTyBF335 g/beH9ZSRq1X/eXeLuyqyV4Tzq/vr2fCLr09hjQXNilv3Ok368rKvySS3uK6C8tKwNVJ Adi8H5HloWcmya4uyK44cnqymTdnS+/YJIntinbccWLJ0ZezvD/1icr73Sl+3jB06v1+ 3uof6Jm7BiYUfIPDBemXzk0DLuWJDouPp5q94AQD7oiKU1o9GqrEWT94LzmbrFvjJIOz 4XIw== X-Gm-Message-State: AOAM531fNJBrF83AgHRSwXfEC2iII+cI720UlAPADQTBmQUDvmch5T2g 09yhxMIvNlYenFjoWBfsCFxH1XcnTk3mTA== X-Google-Smtp-Source: ABdhPJxZ8+AsaRliY3gfPo5E42ATOUAnDDnNWbCAV53YkPd9ncOfs29TSohBB4T6SsiOEu9GSMDomw== X-Received: by 2002:a05:6e02:e01:: with SMTP id a1mr48121289ilk.101.1609303173305; Tue, 29 Dec 2020 20:39:33 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id z63sm32235987ilk.72.2020.12.29.20.39.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Dec 2020 20:39:32 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 8AB97800CCF; Tue, 29 Dec 2020 22:39:30 -0600 (CST) Date: Tue, 29 Dec 2020 22:39:30 -0600 From: Justin Pryzby To: Andrey Borodin Cc: pgsql-hackers@postgresql.org Subject: Re: pglz compression performance, take two Message-ID: <20201230043930.GG25152@telsasoft.com> References: <25991595-1848-4178-AA57-872B10309DA2@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <25991595-1848-4178-AA57-872B10309DA2@yandex-team.ru> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Sat, Dec 26, 2020 at 12:06:59PM +0500, Andrey Borodin wrote: > > 12 дек. 2020 г., в 22:47, Andrey Borodin написал(а): > I've cleaned up comments, checked that memory alignment stuff actually make sense for 32-bit ARM (according to Godbolt) and did some more code cleanup. PFA v2 patch. > > I'm still in doubt should I register this patch on CF or not. I'm willing to work on this, but it's not clear will it hit PGv14. And I hope for PGv15 we will have lz4 or something better for WAL compression. Thanks for registering it. There's some typos in the current patch; farer (further: but it's not your typo) positiion reduce a => reduce the monotonicity what => monotonicity, which lesser good => less good allign: align This comment I couldn't understand: + * As initial compare for short matches compares 4 bytes then for the end + * of stream length of match should be cut -- Justin