Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwt7k-00082H-JH for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jan 2021 20:40:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kwt7j-0005d8-Ds for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jan 2021 20:40:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwt7j-0005cz-49 for pgsql-hackers@lists.postgresql.org; Tue, 05 Jan 2021 20:40:11 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kwt7g-0003Ks-T8 for pgsql-hackers@lists.postgresql.org; Tue, 05 Jan 2021 20:40:10 +0000 Received: by mail-io1-xd2a.google.com with SMTP id m23so650090ioy.2 for ; Tue, 05 Jan 2021 12:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q5H6H+UDNPyUFp+Llqgc5veK4nO4NrwXxeIVaM4d4Xo=; b=vUQsKFqSPU7BDo/viyGa9r0Bzd0lvnjhGxhA4DT94FqJg42MwyOGkowFui8SrSGdbA XT19sAhALqkPdV2xgb1Kc4AyEgHxJtdrHN5PixtnROjntYSQkxJiXKdxCeuSyNR2Y8N7 YzZBHu5kTS39zKNTyWCx73LLKEZbIhQc3nDacL4tTI44Gb68iQuJlNQt6C4GadFR1+kg 6+sbv/MJFnv4zLOb6RxFCXzP6f91svUCmqSyLnFFe4M6ETGNnPWP/K7gFdLkmZQael4p KxLNOTcC7cHHzWT9o3C4S46fY9p2jVlNyJEbjKbdT1rng1pMm9/GSwRH6d3G+BHv6Omj JO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q5H6H+UDNPyUFp+Llqgc5veK4nO4NrwXxeIVaM4d4Xo=; b=aA8MOD2Dk2dJinHYT5u0i5cWVnYU8vBo6UovqxW2v1LabxxoUxS29Cw4EPYAP0gk89 qxP4mR2CBcKziUTyJtumVMXpP5nL9XMLb0/A34YS511URkR2fMnpXYUi7g4LtQFJJ0Mk 7yaGzGCLJh4nk2i2U7YUZHVWtut6GzdpidzZ8N906aD8/X+v2UO2P/OmWEv/gyuqfT0i fkCYlwFh0NK8Lrv6dTup2l7JP8rsaNGDMhL3wDO401XRsYlJ6aUecU2Jt4BcjOtqWeTI VJkPNMfujonp4yC+NJNojoBTxfcqfCTSaCvs06CP88TCoXXlqrbBtUnpGaDDIZoeeZ2/ e4pg== X-Gm-Message-State: AOAM531yYOVhYrXpS4UzEbIItOYdhqdCEO5HT43A/wqlgf8dqV3yNxvb dX8CPnWXwAsfFxsa9qbk3aWGIQ== X-Google-Smtp-Source: ABdhPJzHL2nVyRfSJftPYNEHDaFB5Mo4NLhmdmZTK6cJAi+T2fPYaW2Mm+lA9JAww4D6TglAFPrLmA== X-Received: by 2002:a02:1007:: with SMTP id 7mr1213094jay.73.1609879206906; Tue, 05 Jan 2021 12:40:06 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id t26sm164703ioi.11.2021.01.05.12.40.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jan 2021 12:40:05 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 4F621800F33; Tue, 5 Jan 2021 14:40:04 -0600 (CST) Date: Tue, 5 Jan 2021 14:40:04 -0600 From: Justin Pryzby To: Michael Banck Cc: Daniel Gustafsson , Heikki Linnakangas , Robert Haas , Magnus Hagander , Michael Paquier , Andres Freund , Tomas Vondra , Alvaro Herrera , pgsql-hackers@lists.postgresql.org Subject: Re: Online checksums patch - once again Message-ID: <20210105204004.GL1849@telsasoft.com> References: <20200919021811.GA30557@telsasoft.com> <91DC9350-7269-4B0F-AF87-AE62243D53AD@yesql.se> <329E487A-E0E9-481C-985E-52888302487C@yesql.se> <65E8272D-90AA-4194-A8F0-A8EAA0880B03@yesql.se> <8e1cda9b-1cb9-a634-d383-f757bf67b820@iki.fi> <4D2BC45F-CAE9-451C-AD08-FDB199008E6D@yesql.se> <1B6F5100-6518-4864-8F26-213A45ED6E54@yesql.se> <5ff4cc2c.1c69fb81.6e306.046b@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ff4cc2c.1c69fb81.6e306.046b@mx.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Jan 05, 2021 at 09:29:31PM +0100, Michael Banck wrote: > > @@ -4938,13 +4949,299 @@ GetMockAuthenticationNonce(void) > > /* > > - * Are checksums enabled for data pages? > > + * DataChecksumsNeedWrite > > + * Returns whether data checksums must be written or not > > + * > > + * Are checksums enabled, or in the process of being enabled, for data pages? > > The second "," looks odd and could be ommitted?. Maybe write: > > + * Are checksums on data pages enabled, or in the process of being enabled ?