Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxaed-0003UY-IE for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Jan 2021 19:09:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kxaec-0007LR-6o for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Jan 2021 19:09:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxaeb-0007LI-FT for pgsql-hackers@lists.postgresql.org; Thu, 07 Jan 2021 19:09:02 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxaeW-0001Qp-F8 for pgsql-hackers@postgresql.org; Thu, 07 Jan 2021 19:09:01 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 05C9D5C00DA; Thu, 7 Jan 2021 14:08:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 07 Jan 2021 14:08:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=lc5bbXV2BK6ggxsY+fitWnkRPT41FuepTi+iDV0RVfI=; b=V8EzdfS8 nt6xVx/q+EfVJwEFLzPVsN/BbNduCWDbdM4jKizVrJKixdWox9ZvwR0YHoTQbOYk fNUTndu1Zl0CBYUjhtBSZUEkmFQlhPzwjhYMvS5myKRl/hgzht+4fx8W7dRJ4Tne BrugL5ZkXW58QbNoKcq2k8vn6XDmpLL3/dyEECk1n9El/o4QP+tVg4GDUgyxvHfv 1BBIoRD9MVtfPaw0x79M0LFix9SCollZS3bO+nyvZbQblNjXfZvWA3qutlnnICLH +MmGfrzNvZAEW4/jBsXCSW7AjIJASFEDDrdEks0apCG8PhlrBOnFGT4qaekVaGCy HlXbX8ZLxCw/nw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdegvddguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkgggtugfgjggfsehtkeertddtredunecuhfhrohhmpeetlhhv rghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorh hgqeenucggtffrrghtthgvrhhnpeeufffhjeeiueeuffegvddukeegledtveeivdeiueef ieeivefgteehueefteehvdenucfkphepudeltddrleehrdduledrudejjeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvges rghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.177]) by mail.messagingengine.com (Postfix) with ESMTPA id 16EF61080066; Thu, 7 Jan 2021 14:08:52 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id CF2832A0FE6; Thu, 7 Jan 2021 16:08:49 -0300 (-03) Date: Thu, 7 Jan 2021 16:08:49 -0300 From: Alvaro Herrera To: Bruce Momjian Cc: PostgreSQL-development , Stephen Frost , Masahiko Sawada Subject: Re: Key management with tests Message-ID: <20210107190849.GA9852@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210107150214.GH32172@momjian.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021-Jan-07, Bruce Momjian wrote: > All the tests pass now. The current src/test directory is 19MB, and > adding these tests takes it to 23MB, or a 20% increase. That seems like > a lot. It is testing 128-bit and 256-bit keys --- should we do fewer > tests, or just test 256, or use gzip to compress the tests by 50%? > (Does every platform have gzip?) So the tests are about 95% of the patch ... do we really need that many tests? -- Álvaro Herrera