Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLkh-00068S-97 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 15:38:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kzLkf-0001EG-U1 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 15:38:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLkf-0001E8-Hq for pgsql-hackers@lists.postgresql.org; Tue, 12 Jan 2021 15:38:33 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kzLkY-0000wo-F2 for pgsql-hackers@lists.postgresql.org; Tue, 12 Jan 2021 15:38:32 +0000 Received: by mail-io1-xd33.google.com with SMTP id d9so4920286iob.6 for ; Tue, 12 Jan 2021 07:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=I7pqPBhf2WQ7YVv5CQqTiUDjTt6ScJHK6JUzKysXzwg=; b=VZXdMVTA7vaNUdKpVUnRkm9WisGI9C1zB3VVIMWpONuvQj+EI8op/kz5JZZRv+9XDO 62jGHMAQAyDCnCQs0TeBUb/djHQvZf/STbVnJeRUgRSOyIhVPt+xWoTWKGWLIhrIuyGE LWigyKgBXg/SPjRONXTzEgYjpH65Cd2m2oLD731oVFKGojDA+AwhVLGNChfy2dtKJuRe W/DG1vmmPXT0ZraNsv9hOzbxlxfDGT2vTZmGNoXM91MRAyaM4qncqzTJngs0Do+Z6StE JSnvhliHsDnM40Dns1q8g0Sj0NDsDuBLARG6pBL4EBMv+7Jb7phtLocqxlSHs7Po0uBv 3hJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I7pqPBhf2WQ7YVv5CQqTiUDjTt6ScJHK6JUzKysXzwg=; b=W4H/UXOeb6dRAgBxjhkixvbxhxoj1Jjxs4nv0b9j7UfNUCE+JUgQFzK1NVlOKdfgTU eC1x4Pjz8/xkFUFLn4dZGHM2s9PkJPeXCCTBOb/+er12FAA9Kw+MxXX3l9qCpTSVatPM 7Gqi0o0Siwha4D7JXQzARO4GAxhcR6nHF+H7uEOXWSd3cTpmHVX/PMQwh2P+y1Aeo1SY ufmvZXOrSl4Q6NITc+ncbbNOtpKoMrKYDmoHICv4Kl3fG+XirQdgUtRV79Uq4qCeFiwf ynA4+RU+k4fVYgwsbbF83AtgPKpeIPHeCYuGvuyC+QSEGyqh2XCcg7tNeHnw5qC5JPqj ZafQ== X-Gm-Message-State: AOAM533HzudVDw4E+shTiKyzlabY/ey4n+IZgy8txFbJzPvOCjA6/XX8 qb8tLY4fmqx2qJL185KK34RFvg== X-Google-Smtp-Source: ABdhPJxJvyM1iU58j97F3aPXsDCSK3G1uOKWJWACngS8Q1z1HPsEQBOlhFh4pLiANC7J3qEKYCAImw== X-Received: by 2002:a6b:d20d:: with SMTP id q13mr3703944iob.71.1610465905551; Tue, 12 Jan 2021 07:38:25 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id a17sm2758588ilc.77.2021.01.12.07.38.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2021 07:38:24 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 7EBD980095C; Tue, 12 Jan 2021 09:38:22 -0600 (CST) Date: Tue, 12 Jan 2021 09:38:22 -0600 From: Justin Pryzby To: Konstantin Knizhnik Cc: Tomas Vondra , Konstantin Knizhnik , Denis Smirnov , Daniil Zakhlystov , Andrey Borodin , Dilip Kumar , PostgreSQL Hackers Subject: Re: libpq compression Message-ID: <20210112153822.GA1849@telsasoft.com> References: <93027ee4-fefa-a8ca-2cc7-245c912bf824@postgrespro.ru> <20210109203119.GL1849@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Jan 12, 2021 at 08:44:43AM +0300, Konstantin Knizhnik wrote: > On 11.01.2021 20:38, Tomas Vondra wrote: > > 1) Fixes the MSVC makefile. The list of files is sorted alphabetically, > > so I've added the file at the end. > Thank you This is still failing the windows build. I think you need something like this, which I have in my zstd/pg_dump patch. --- a/src/tools/msvc/Solution.pm +++ b/src/tools/msvc/Solution.pm @@ -307,6 +307,7 @@ sub GenerateFiles HAVE_LIBXML2 => undef, HAVE_LIBXSLT => undef, HAVE_LIBZ => $self->{options}->{zlib} ? 1 : undef, + HAVE_LIBZSTD => $self->{options}->{zstd} ? 1 : undef, I think we should come up with an minimal, prelimininary 0001 patch which is common between the 3 compression patches (or at least the two using zstd). The ./configure changes and a compressionlibs struct would also be included. I'm planning to do something like this with the next revision of my patchset. -- Justin