Date: Mon, 18 Jan 2021 10:51:55 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	Tom Kincaid <tomjohnkincaid@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Stephen Frost <sfrost@snowman.net>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Subject: Re: Key management with tests
Message-ID: <20210118155155.GC18352@momjian.us>
References: 
 <CA+Tgmoaon7NE0FxH7HXiF4cFJvkn0qMui_oxyvkO6Ri9+D7u4A@mail.gmail.com>
 <20210115214719.GE8740@momjian.us>
 <20210115223756.si7s3vpa3ewji6u6@alap3.anarazel.de>
 <20210116002132.GG8740@momjian.us>
 <20210116005624.ai7gyqee5c6fvnwh@alap3.anarazel.de>
 <20210116014910.GI8740@momjian.us>
 <20210116042036.cpuadvs2bdbsblia@alap3.anarazel.de>
 <CAKPRjUN4jh=_1vj6hqmRgXc8HAVCWHa6vo8PuGFJZ1up_j-rzw@mail.gmail.com>
 <CAA4eK1+PxcXSvhWen3ByWz20o6xekf5iDyf7hac-_W-d8TEUfQ@mail.gmail.com>
 <20210117065847.yim3rcio4pql3eqr@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210117065847.yim3rcio4pql3eqr@alap3.anarazel.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sat, Jan 16, 2021 at 10:58:47PM -0800, Andres Freund wrote:
> Hi,
> 
> On 2021-01-17 11:54:57 +0530, Amit Kapila wrote:
> > On Sun, Jan 17, 2021 at 5:38 AM Tom Kincaid <tomjohnkincaid@gmail.com> wrote:
> > > Admittedly I am a novice on this topic, and the majority of the
> > > PostgreSQL source code, however I am hopeful enough (those of you who
> > > know me understand that I suffer from eternal optimism) that I am
> > > going to attempt to help.
> > >
> > > Is there a design document for a Postgres feature of this size and
> > > scope that people feel would serve as a good example? Alternatively,
> > > is there a design document template that has been successfully used in
> > > the past?
> > >
> > 
> > We normally write the design considerations and choices we made with
> > the reasons in README and code comments. Personally, I am not sure if
> > there is a need for any specific document per-se but a README and
> > detailed comments in the code should suffice what people are worried
> > about here.
> 
> Right. It could be a README file, or a long comment at a start of one of
> the files. It doesn't matter too much. What matters is that people that
> haven't been on those phone call can understand the design and the
> implications it has.

OK, so does the wiki page contain most of what you want, but is missing
the connection between the design and the code?

	https://wiki.postgresql.org/wiki/Transparent_Data_Encryption

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee