Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1Xhn-000249-DW for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 16:48:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l1Xhl-0007nW-Ow for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 16:48:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1Xhk-0007nP-PQ for pgsql-hackers@lists.postgresql.org; Mon, 18 Jan 2021 16:48:37 +0000 Received: from [66.111.4.27] (helo=out3-smtp.messagingengine.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1Xhh-0003sR-Dy for pgsql-hackers@lists.postgresql.org; Mon, 18 Jan 2021 16:48:36 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D34705C01A9; Mon, 18 Jan 2021 11:48:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 18 Jan 2021 11:48:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=Fs3XR1uXbBOtDo6MoMjwIUS1wYuNWEgn9XgsaY6Rgnw=; b=QpgTJ3KV npssdxlMD9YZrHJjmi8tcyFas+F5UIw2wpmsujuDIIcpjFWD0bmOPh7T30TqWNPc +Lw4oeCnvIP1UtGGEo/bqjIEVjw4OTdGsgJAn9HqN9d0SMAuMqeRT+cCatHe/JO8 lILTPVmetKvc2tEGpCpepd/fAHI9ZH5ac+EdMO1FwBGgAkEfe9gpWnDJbTMK+ZAN pSqxgX7z+7hfB9hGXPgfdN34/AJRHrvM1ByoPIrw/J8Al4seLNgLki47K2GfWN5p btMLqIcmgJreXtOaAwoC7UgFyHwwZk+J9qQF3lqfyqWzWI2+Bt4VLJuhuJ6WLAzx QJazrNoNz9IHaA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugfgjggfsehtkeertddtredunecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpefghfehgfdtiedugfdvkeehgfeggfehjeekjefhhfejjeef tdfgkedugfevjedvtdenucffohhmrghinhepphhoshhtghhrrdgvshenucfkphepudeltd drleehrdduledrudejjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.177]) by mail.messagingengine.com (Postfix) with ESMTPA id 4408A108005B; Mon, 18 Jan 2021 11:48:21 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 817302A0928; Mon, 18 Jan 2021 13:48:18 -0300 (-03) Date: Mon, 18 Jan 2021 13:48:18 -0300 From: Alvaro Herrera To: Robert Haas Cc: Pg Hackers Subject: Re: support for MERGE Message-ID: <20210118164818.GA32115@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.27 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021-Jan-18, Robert Haas wrote: > On Thu, Dec 31, 2020 at 8:48 AM Alvaro Herrera wrote: > > Here's a rebase of Simon/Pavan's MERGE patch to current sources. I > > cleaned up some minor things in it, but aside from rebasing, it's pretty > > much their work (even the commit message is Simon's). > > It's my impression that the previous discussion concluded that their > version needed pretty substantial design changes. Is there a plan to > work on that? Or was some of that stuff done already? I think some of the issues were handled as I adapted the patch to current sources. However, the extensive refactoring that had been recommended in the old threads has not been done. I have these two comments mainly: https://postgr.es/m/CABOikdOeraX0RKojBs0jZxY5SmbQF3GJBP0+Rat=2g+VQsA+9g@mail.gmail.com https://postgr.es/m/7168.1547584387@sss.pgh.pa.us I'll try to get to those, but I have some other patches that I need to handle first. -- Álvaro Herrera Valdivia, Chile