Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1XzG-0002rx-HJ for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 17:06:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l1XzF-0006p9-Ea for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 17:06:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1XzF-0006p2-89 for pgsql-hackers@lists.postgresql.org; Mon, 18 Jan 2021 17:06:41 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1XzC-00040x-Rn for pgsql-hackers@postgresql.org; Mon, 18 Jan 2021 17:06:40 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1l1Xz9-00021J-7u; Mon, 18 Jan 2021 12:06:35 -0500 Date: Mon, 18 Jan 2021 12:06:35 -0500 From: Bruce Momjian To: Amit Kapila Cc: Tom Kincaid , Andres Freund , Robert Haas , Thomas Munro , PostgreSQL-development , Stephen Frost , Masahiko Sawada Subject: Re: Key management with tests Message-ID: <20210118170635.GA4602@momjian.us> References: <20210115214719.GE8740@momjian.us> <20210115223756.si7s3vpa3ewji6u6@alap3.anarazel.de> <20210116002132.GG8740@momjian.us> <20210116005624.ai7gyqee5c6fvnwh@alap3.anarazel.de> <20210116014910.GI8740@momjian.us> <20210116042036.cpuadvs2bdbsblia@alap3.anarazel.de> <20210118155037.GB18352@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210118155037.GB18352@momjian.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Mon, Jan 18, 2021 at 10:50:37AM -0500, Bruce Momjian wrote: > OK, I looked at that and it is good, and I see my patch is missing that. > Are people looking for me to take the wiki content, expand on it and tie > it to the code that will be applied, or something else like all the > various crypto options and why we chose what we did beyond what is > already on the wiki? I can easily go from what we have on the wiki to > implementation code steps, but the other part is harder to explain and > that is why I offered to talk to people via voice. Just to clarify why voice calls can be helpful --- if you have to get into "you have to understand X to understand Y", that's where a voice call works best, because understanding X will require understanding A/B/C, and everyone's missing pieces are different, so you have to customize it for the individual. You can explain some of this in a README, but trying to cover all of it leads to a combinatorial problem of trying to explain everything. Ideally the wiki page can be expanded so people can ask and answer all posted issues, perhaps in a Q&A format. Someone could go through the archives and post why certain decisions were made, and link to the original emails. I have to admit I was kind of baffled that the wiki page wasn't sufficient, because it is one of the longest Postgres feature explanations I have seen, but I now think the missing part is tying the wiki contents to the code implementation. If that is it, please confirm. If it is something else, also explain. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee