Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l59ed-0008CR-7Y for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Jan 2021 15:56:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l59ec-0006vQ-6S for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Jan 2021 15:56:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l59dS-0003ia-Bu for pgsql-hackers@lists.postgresql.org; Thu, 28 Jan 2021 15:55:06 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l59dQ-0003Ta-Lu for pgsql-hackers@postgresql.org; Thu, 28 Jan 2021 15:55:06 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 562B35C0238; Thu, 28 Jan 2021 10:55:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 28 Jan 2021 10:55:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=1/he+N6nA17mQHP3Rd/bXkPSRS5yKE2sDhHFgDgaofo=; b=KmHZruIV IOZg7DvfH7E6uXCQW7B8VsEL6ESJawjOb0nunyWjDZHmr8dvoenfOAR4R57Geqzc Db29PKgPjHX3JU6opFtOM2uK/MkumSrk35/FHLkKKD1LAbN4fGILAuUzPs0avycL /B3iT4fz/VSUvm6YIlmIa1kgWEaLvayRZGgZbTaM1qZpY1VgoiBi16yq6Zn5qIAU yOnljt6Gqpb7mhIcm51CsT8PBozRkRpcV9uvicR6gJSiuJ5QXUz3rfp4pT5hxgWs LC1jkTcDHuhNOg2Q/AfHeaOtsezN5u/M/hlTMwA7CzXLDJD2WKu92KDNfoCZTNu7 Z0EcHmv0oWRfTw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugfgjggfsehtkeertddtredunecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeeufffhjeeiueeuffegvddukeegledtveeivdeiueefieei vefgteehueefteehvdenucfkphepudeltddrleehrdduledrudejjeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghl vhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.177]) by mail.messagingengine.com (Postfix) with ESMTPA id D01821080057; Thu, 28 Jan 2021 10:55:02 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 2AEC82A0D41; Thu, 28 Jan 2021 12:55:00 -0300 (-03) Date: Thu, 28 Jan 2021 12:55:00 -0300 From: Alvaro Herrera To: Tom Lane Cc: Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: strange error reporting Message-ID: <20210128155500.GA3440@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2338295.1611697523@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021-Jan-26, Tom Lane wrote: > Alvaro Herrera writes: > > pgbench has one occurrence of the old pattern in master, in line 6043. > > However, since doConnect() returns NULL when it gets CONNECTION_BAD, > > that seems dead code. This patch kills it. > > Oh ... I missed that because it wasn't adjacent to the PQconnectdbParams > call :-(. You're right, that's dead code and we should just delete it. Pushed, thanks. -- Álvaro Herrera 39°49'30"S 73°17'W "Pensar que el espectro que vemos es ilusorio no lo despoja de espanto, sólo le suma el nuevo terror de la locura" (Perelandra, C.S.Lewis)