Date: Mon, 1 Feb 2021 09:39:31 +0100
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Korotkov <aekorotkov@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Dian M Fay <dian.m.fay@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Justin Pryzby <pryzby@telsasoft.com>,
	David Steele <david@pgmasters.net>,
	Nikita Glukhov <n.gluhov@postgrespro.ru>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Fetter <david@fetter.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Oleksandr Shulgin <oleksandr.shulgin@zalando.de>,
	Robert Haas <robertmhaas@gmail.com>,
	Michael Paquier <michael.paquier@gmail.com>,
	Oleg Bartunov <obartunov@gmail.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Message-ID: <20210201083931.mhwqwrhbk3claoib@localhost>
References: <20210120190857.vvtwtabubwxzeraq@localhost>
 <C8OK3JQNE1KN.2H0O0RCBD576E@lamia>
 <20210121115851.3kwqkyks4irvf452@localhost>
 <CAFj8pRAAd8D7iH1bNb66CHmBEmUxn8GQNiFO08OF8mt489AdmQ@mail.gmail.com>
 <CAPpHfdsxooMErabKUEjg9N4MFs_d1tty3ZNai0Lr28TOQasNKg@mail.gmail.com>
 <CAPpHfdufrsVMA3ugkiwOvWghTyhDyUoPE=WW3DiyXStwBB=8JA@mail.gmail.com>
 <3242132.1612131805@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3242132.1612131805@sss.pgh.pa.us>
Precedence: bulk

> On Fri, Jan 29, 2021 at 7:01 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> Pushed with minor cleanup.

Thanks a lot!

> On Sun, Jan 31, 2021 at 05:23:25PM -0500, Tom Lane wrote:
>
> thorntail seems unhappy:
>
> [From 7c5d57c...]
> Fix portability issue in new jsonbsubs code.
>
> On machines where sizeof(Datum) > sizeof(Oid) (that is, any 64-bit
> platform), the previous coding would compute a misaligned
> workspace->index pointer if nupper is odd.  Architectures where
> misaligned access is a hard no-no would then fail.  This appears
> to explain why thorntail is unhappy but other buildfarm members
> are not.

Yeah, that was an unexpected issue, thanks! I assume few other failing
buildfarm members are the same, as they show similar symptoms (e.g.
mussurana or ibisbill).