Date: Wed, 3 Feb 2021 00:53:42 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexey Kondratov <a.kondratov@postgrespro.ru>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Steve Singer <steve@ssinger.info>,
	pgsql-hackers@lists.postgresql.org,
	Robert Haas <robertmhaas@gmail.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Jose Luis Tallon <jltallon@adv-solutions.net>
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on
 the fly
Message-ID: <20210203065342.GX7450@telsasoft.com>
References: <20210127213658.GA736@alvherre.pgsql>
 <55c6c1526b94d2caf54c33262fe00674@postgrespro.ru>
 <e15777decc533006c9dbe4988bd66d31@postgrespro.ru>
 <YBTC0IYIGmyYfiIn@paquier.xyz>
 <1c506564e2a732ec17790bd8c34f042e@postgrespro.ru>
 <YBiro+n0767QDXSA@paquier.xyz>
 <YBpEsxZxIVn0zyFM@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YBpEsxZxIVn0zyFM@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Feb 03, 2021 at 03:37:39PM +0900, Michael Paquier wrote:
> index 627b36300c..4ee3951ca0 100644
> --- a/doc/src/sgml/ref/reindex.sgml
> +++ b/doc/src/sgml/ref/reindex.sgml
> @@ -293,8 +311,30 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { IN
>     respectively. Each partition of the specified partitioned relation is
>     reindexed in a separate transaction. Those commands cannot be used inside
>     a transaction block when working on a partitioned table or index.
> +   If a <command>REINDEX</command> command fails when run on a partitioned
> +   relation, and <literal>TABLESPACE</literal> was specified, then it may not
> +   have moved all indexes to the new tablespace. Re-running the command
> +   will rebuild again all the partitions and move previously-unprocessed

remove "again"

> +   indexes to the new tablespace.
> +  </para>
> +  
> +  <para>
> +   When using the <literal>TABLESPACE</literal> clause with
> +   <command>REINDEX</command> on a partitioned index or table, only the
> +   tablespace references of the partitions are updated. As partitioned indexes

I think you should say "of the LEAF partitions ..".  The intermediate,
partitioned tables are also "partitions" (partitioned partitions if you like).

> +   are not updated, it is recommended to separately use
> +   <command>ALTER TABLE ONLY</command> on them to achieve that.

Maybe say: "..to set the default tablespace of any new partitions created in
the future".

-- 
Justin