Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7gUG-0008M8-Op for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Feb 2021 15:24:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l7gUF-0000QP-L1 for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Feb 2021 15:24:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7gUF-0000QG-E6 for pgsql-hackers@lists.postgresql.org; Thu, 04 Feb 2021 15:24:03 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7gUD-0007j8-3h for pgsql-hackers@postgresql.org; Thu, 04 Feb 2021 15:24:03 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 35852F9B; Thu, 4 Feb 2021 10:23:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 04 Feb 2021 10:23:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=RSrRlFK1ac1tK6UmaaxK3fYRt76MPO57Q5qqAO3aRG4=; b=tLUyqW5t nq5BJIfBwZQRp+kLOx1fYDZXoT8herbbz7TTiRLm99+NIXr1d/8OUFJxUv6EKH0W N7PPXIvVpNUSI28/m15tmuvtOYCqjIKmcBVDvs34+IT3G939RxThG2Q7zZGFptMO 45S2LN/X+uXeElpJTHwPzh03tHdtVHEkAKwLCQUHwE37rRbwRd0Uuo/BrjJw0BQp o9sFbP4erHdTyHQHfXyUSap99VbCFYOd6T1Y5rFCbB4t3r0Zg4wTTp1ObRQfSZq/ uyzLPaNEHM2B3ACGInW9y/BNTGf1rj55jr3IDtU/we8qtnK3DbbqHS/RPQtsiJ38 TZNv1K0Zbq4XwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeggdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugfgjggfsehtkeertddtredunecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeeufffhjeeiueeuffegvddukeegledtveeivdeiueefieei vefgteehueefteehvdenucfkphepudeltddrleehrdduledrudejjeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghl vhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.177]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F37B108006F; Thu, 4 Feb 2021 10:23:56 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id D9DF22A0E0B; Thu, 4 Feb 2021 12:23:53 -0300 (-03) Date: Thu, 4 Feb 2021 12:23:53 -0300 From: Alvaro Herrera To: Andres Freund Cc: Heikki Linnakangas , Petr Jelinek , pgsql-hackers , Thomas Munro Subject: Re: Snapbuild woes followup Message-ID: <20210204152353.GA6117@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210125204813.iavrp2seuaaysmxa@alap3.anarazel.de> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021-Jan-25, Andres Freund wrote: > See attached patch... Looks good to me. I was wondering if there would be a point in using a FullTransactionId instead of an unadorned one. I don't know what's the true risk of an Xid wraparound occurring here, but it seems easier to reason about. But then that's probably a larger change to make all of snapbuild use FullTransactionIds, so not for this patch to worry about. -- Álvaro Herrera 39°49'30"S 73°17'W