Date: Wed, 10 Feb 2021 00:58:05 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ronan Dunklau <ronan@dunklau.fr>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	pgsql-hackers@postgresql.org
Subject: Re: Preserve attstattarget on REINDEX CONCURRENTLY
Message-ID: <20210210065805.GG20012@telsasoft.com>
References: <16628084.uLZWGnKmhe@laptop-ronand>
 <d4df50ad-fcb0-bc25-d0a4-71e0165b8511@enterprisedb.com>
 <80274775044a11f6f42af9c39640a055@dunklau.fr>
 <YByqzE9qu16vuEB+@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YByqzE9qu16vuEB+@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Feb 05, 2021 at 11:17:48AM +0900, Michael Paquier wrote:
> Let's copy this data in index_concurrently_swap() instead.  The
> attached patch does that, and adds a test cheaper than what was
> proposed.  There is a minor release planned for next week, so I may be

> +++ b/src/test/regress/sql/create_index.sql
> @@ -1103,6 +1104,13 @@ SELECT starelid::regclass, count(*) FROM pg_statistic WHERE starelid IN (
>    'concur_exprs_index_pred'::regclass,
>    'concur_exprs_index_pred_2'::regclass)
>    GROUP BY starelid ORDER BY starelid::regclass::text;
> +-- attstattarget should remain intact
> +SELECT attrelid::regclass, attnum, attstattarget
> +  FROM pg_attribute WHERE attrelid IN (
> +    'concur_exprs_index_expr'::regclass,
> +    'concur_exprs_index_pred'::regclass,
> +    'concur_exprs_index_pred_2'::regclass)
> +  ORDER BY 'concur_exprs_index_expr'::regclass::text, attnum;

If I'm not wrong, you meant to ORDER BY attrelid::regclass::text, attnum;

-- 
Justin