Date: Fri, 19 Feb 2021 17:46:51 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	Daniel Verite <daniel@manitou-mail.org>,
	Matthieu Garrigues <matthieu.garrigues@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Dave Cramer <davecramer@postgres.rocks>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Craig Ringer <craig@2ndquadrant.com>,
	Vaishnavi Prabakaran <vaishnaviprabakaran@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Michael Paquier <michael.paquier@gmail.com>,
	Claudio Freire <klaussfreire@gmail.com>,
	Heikki Linnakangas <heikki.linnakangas@iki.fi>
Subject: Re: PATCH: Batch/pipelining support for libpq
Message-ID: <20210219204651.GA32724@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CALNJ-vQMeFYb==v5ySLy_oNqoHJ_pt2+9cKyj1pzy_NJKU7H9w@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi,

On 2021-Feb-19, Zhihong Yu wrote:

> Hi,
> +static int pqBatchProcessQueue(PGconn *conn);
> 
> I was suggesting changing:
> 
> +int
> +PQexitBatchMode(PGconn *conn)
> 
> to:
> 
> +static int
> +PQexitBatchMode(PGconn *conn)

I understand that, but what I'm saying is that it doesn't work.
pqBatchProcessQueue can be static because it's only used internally in
libpq, but PQexitBatchMode is supposed to be called by the client
application.

-- 
Álvaro Herrera       Valdivia, Chile
"No necesitamos banderas
 No reconocemos fronteras"                  (Jorge González)