Date: Wed, 24 Feb 2021 01:53:03 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Josef =?utf-8?B?xaBpbcOhbmVr?= <josef.simanek@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improvements and additions to COPY progress reporting
Message-ID: <20210224075303.GI14772@telsasoft.com>
References: 
 <CALj2ACWNo1jSQDnGTx+v9jR27BOen59sWdp+j+JrWwuFuhB8Rg@mail.gmail.com>
 <CAEze2WhbvkoSm6zs7Jaupe+Ln0ttP6m1Fb3WLodo8-SdTxq6WQ@mail.gmail.com>
 <de9df4db-a8e8-ec5f-9540-c5834ab76345@enterprisedb.com>
 <CAEze2Wi3gmq1M+nyexfOHZ_wXYBP7B+9eoQMKGWY+7c2qJ0n8g@mail.gmail.com>
 <0eb0a7e5-031d-51b6-b1c7-9804915d44f2@enterprisedb.com>
 <CALj2ACUHvsTm3VFa3_baMK2y2jVYbA6Xff302Qesa1njRznUdg@mail.gmail.com>
 <YDC3tifoiJOJ2zUY@paquier.xyz>
 <CALj2ACXQrFM+DSN9xr=+yRotBufnC_xgG-FQ6VXAUZRPihZAew@mail.gmail.com>
 <YDGZ1jnuwdjEn+4P@paquier.xyz>
 <CAEze2Wjd9JQS_LjLS+cSsuF0Z28Xg4DG9cKi-XBAAjWxCtf_nA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAEze2Wjd9JQS_LjLS+cSsuF0Z28Xg4DG9cKi-XBAAjWxCtf_nA@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sun, Feb 21, 2021 at 08:10:09PM +0100, Matthias van de Meent wrote:
> Subject: [PATCH v9 1/3] Add progress-reported components for COPY progress
>  reporting

>  			/* Increment amount of processed tuples and update the progress */
>  	/* Increment amount of processed tuples and update the progress */

Ideally, this would say "number of processed tuples"

> Subject: [PATCH v9 2/3] Add backlinks to progress reporting documentation

I think these should say that they report their progress *in* the view (not
"to"):

> +    Each backend running <command>ANALYZE</command> will report its progress to
> +    the <structname>pg_stat_progress_analyze</structname> view. See

> +    Each backend running <command>CLUSTER</command> will report its progress to
> +    the <structname>pg_stat_progress_cluster</structname> view. See

> +    Each backend running <command>COPY</command> will report its progress to
> +    the <structname>pg_stat_progress_copy</structname> view. See

> +    Each backend running <command>CREATE INDEX</command> will report its
> +    progress to the <structname>pg_stat_progress_create_index</structname>

> +    Each backend running <command>REINDEX</command> will report its progress
> +    to the <structname>pg_stat_progress_create_index</structname> view. See

Like this one:

> +    Each backend running <command>VACUUM</command> without the
> +    <literal>FULL</literal> option will report its progress in the

I'm sorry I didn't include that in last week's message.  You could also write:

|"The progress of each backend running >ANALYZE< is reported in the >pg_stat_progress_analyze< view."

Looking at the existing docs:

https://www.postgresql.org/docs/devel/progress-reporting.html#COPY-PROGRESS-REPORTING
| OID of the table on which the COPY command is executed

Maybe it should say ".. is executing".  Or ".. being executed":
| OID of the table on which the COPY command is being executed

-- 
Justin