Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFQcD-0001wi-Fj for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Feb 2021 00:04:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lFQcA-0001h4-FQ for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Feb 2021 00:04:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFQcA-0001gx-8R for pgsql-hackers@lists.postgresql.org; Fri, 26 Feb 2021 00:04:14 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFQc7-00088v-0G for pgsql-hackers@lists.postgresql.org; Fri, 26 Feb 2021 00:04:13 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 98612A30; Thu, 25 Feb 2021 19:04:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 25 Feb 2021 19:04:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=BLMhluQCMfU/6tK0w1peuDsL3rEEn9qE3GWaTIFMRwQ=; b=MIPkUUgn eyRKuJUGtxqo58PnNLJBJWb39Lyd+qoKeb1lZ0YxonRRxQhTt6JSUfN+i0Ff4Pjo 9mTtyzqGfm4dts30KtTnyxAD2Ne5x9QsAF95D8859cz+D255X3ocg+1D37zAIpaU 4+sqPb83/gVt36+HqHsP2LeYT4GF55tEloefwBrPgCVa+cO9sTUqQE8nky8iJ9dU cr/e9GdymorO4UexW8sloCM8n2CPOu6139y2UtzBUIramffdexu2GOLO+hd3PcYW aGzJpKoW+DWrgvo2NZT/aypvfagdNl97itdB/I8BxNyIp4sTU4x/7AFBmptfyKjP dNQ+pA8gsRkjYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrledtgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggugfgjfgesthekre dttderudenucfhrhhomheplmhlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgv segrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnheptefgvdevvdelue ehtdeiuddutdejgffhffdugedvkeffvdektdekffeuueekveefnecukfhppeduledtrdel hedrudelrdelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.95]) by mail.messagingengine.com (Postfix) with ESMTPA id 8375F1080063; Thu, 25 Feb 2021 19:04:03 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 9EDB12A0F80; Thu, 25 Feb 2021 21:04:00 -0300 (-03) Date: Thu, 25 Feb 2021 21:04:00 -0300 From: =?iso-8859-1?Q?=C1lvaro?= Herrera To: "iwata.aya@fujitsu.com" , "k.jamison@fujitsu.com" Cc: "tsunakawa.takay@fujitsu.com" , 'Kyotaro Horiguchi' , "pgsql-hackers@lists.postgresql.org" Subject: Re: libpq debug log Message-ID: <20210226000400.GA12884@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3800ecbd-9256-4646-bf38-78a325ab56aa@www.fastmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This assert I added? > +static bool > +pqTraceMaybeBreakLine(int size, PGconn *conn) > +{ > + Assert(conn->be_msg->length > 0); It breaks. Maybe there's a good reason, maybe there ain't, but in the meantime I just removed it. -- Álvaro Herrera Valdivia, Chile "Para tener más hay que desear menos"