Date: Fri, 5 Mar 2021 10:41:09 -0300
From: "alvherre@alvh.no-ip.org" <alvherre@alvh.no-ip.org>
To: "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>
Cc: 'Tom Lane' <tgl@sss.pgh.pa.us>,
	"iwata.aya@fujitsu.com" <iwata.aya@fujitsu.com>,
	"k.jamison@fujitsu.com" <k.jamison@fujitsu.com>,
	'Kyotaro Horiguchi' <horikyota.ntt@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq debug log
Message-ID: <20210305134109.GA21852@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <TYAPR01MB2990065BA2D1E35657516C10FE969@TYAPR01MB2990.jpnprd01.prod.outlook.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210305134109.GA21852%40alvherre.pgsql>
Precedence: bulk

On 2021-Mar-05, tsunakawa.takay@fujitsu.com wrote:

> From: Tom Lane <tgl@sss.pgh.pa.us>
> > But I think passing the message start address explicitly might be
> > better than having it understand the buffering behavior in enough
> > detail to know where to find the message.  Part of the point here
> > (IMO) is to decouple the tracing logic from the core libpq logic, in
> > hopes of not having common-mode bugs.
> 
> Ouch, you're perfectly right.  Then let's make the signature:
> 
>     void pqLogMessage(PGconn *conn, const char *message, bool toServer);

Yeah, looks good!  I agree that going this route will result in more
trustworthy trace output.

-- 
Álvaro Herrera                            39°49'30"S 73°17'W