Date: Fri, 12 Mar 2021 04:36:50 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	David Steele <david@pgmasters.net>,
	Ildus Kurbangaliev <i.kurbangaliev@gmail.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] Custom compression methods
Message-ID: <20210312103650.GR8796@telsasoft.com>
References: 
 <CAFiTN-uxeRxCROr50e62eqog0nAi+FFi1m25f_D5D0-QsdDp1Q@mail.gmail.com>
 <20210306195751.GW29832@telsasoft.com>
 <CAFiTN-tjZrn1OrykBUvzf4_GU7HUPBjSbdwM8_SVnD-9gMWHdA@mail.gmail.com>
 <CA+TgmoZ9sWS_8OHqvTAhmRX-2PoK4UMFiSU4QgKbhAosT1RTzQ@mail.gmail.com>
 <CAFiTN-sBF8ZK3XP105AybsH5s5KtyWoRNbYzgPXQOKACdn1a_Q@mail.gmail.com>
 <CA+TgmoY5gTwurzHM3Ofv-jVTXGkmJqYib_+B9ev_7JKop9NmjQ@mail.gmail.com>
 <CAFiTN-sK1TbCpbFRDF+-TaG4G_hw4S4vUKujGepwg_A7On9UNg@mail.gmail.com>
 <20210311032057.GZ2021@telsasoft.com>
 <CAFiTN-tzAzGroskaqm-cCOctHxBpDccXkKsDPBX4RTv9ETpBNw@mail.gmail.com>
 <CAFiTN-snEyq1QG5TgkoQeVyCvJHqw5m5Nq416ZpPcs372Z-4Gw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFiTN-snEyq1QG5TgkoQeVyCvJHqw5m5Nq416ZpPcs372Z-4Gw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210312103650.GR8796%40telsasoft.com>
Precedence: bulk

I think these names need to be more specific.

+typedef enum CompressionId
+{
+        PGLZ_COMPRESSION_ID = 0,
+        LZ4_COMPRESSION_ID = 1
+

CompressionId, PGLZ_COMPRESSION_ID, LZ4_COMPRESSION_ID are also being used by
Andrey's WAL compression patch.  I suggested he use a prefix, but your patch is
also of limited scope (TOAST).

-- 
Justin