Date: Sat, 13 Mar 2021 10:46:12 -0800
From: Noah Misch <noah@leadboat.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	"Andrey M. Borodin" <x4mmm@yandex-team.ru>,
	Stephen Frost <sfrost@snowman.net>,
	Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_amcheck contrib application
Message-ID: <20210313184612.GA3195145@rfd.leadboat.com>
References: <E9EE1C23-9C17-45DF-8C0B-D6BE16CF18AF@enterprisedb.com>
 <CA+TgmobTsaZxiyqb3On-nYcS+TKXebb2sHMUAoyn-vviT8kevA@mail.gmail.com>
 <CAH2-WzmZJ3MWjaSEaysmkP8A7WL_TiCwOS8eT88yc-bwHgLOKg@mail.gmail.com>
 <CAH2-WznpwULZ3uJ1_6WXvNMXYbOy8k8tYs3r=qSdGmZeRd6tDw@mail.gmail.com>
 <CA+TgmoZUJ4j31CbnUz-DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com>
 <CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
 <A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
 <CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
 <9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
 <F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210313184612.GA3195145%40rfd.leadboat.com>
Precedence: bulk

On Fri, Mar 12, 2021 at 05:04:09PM -0800, Mark Dilger wrote:
> > On Mar 12, 2021, at 3:24 PM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
> > 
> > and the second deals with an apparent problem with IPC::Run shell expanding an asterisk on some platforms but not others.  That second one, if true, seems like a problem with scope beyond the pg_amcheck project, as TestLib::command_checks_all uses IPC::Run, and it would be desirable to have consistent behavior across platforms.

> > One of pg_amcheck's regression tests was passing an asterisk through
> > TestLib's command_checks_all() command, which gets through to
> > pg_amcheck without difficulty on most platforms, but appears to get
> > shell expanded on Windows (jacana) and AIX (hoverfly).

For posterity, I can't reproduce this on hoverfly.  The suite fails the same
way at f371a4c and f371a4c^.  More-recently (commit 58f5749), the suite passes
even after reverting f371a4c.  Self-contained IPC::Run usage also does not
corroborate the theory:

[nm@power8-aix 8:0 2021-03-13T18:32:23 clean 0]$ perl -MIPC::Run -e 'IPC::Run::run "printf", "%s\n", "*"'
*
[nm@power8-aix 8:0 2021-03-13T18:32:29 clean 0]$ perl -MIPC::Run -e 'IPC::Run::run "sh", "-c", "printf %s\\\\n *"'
COPYRIGHT
GNUmakefile.in
HISTORY
Makefile
README
README.git
aclocal.m4
config
configure
configure.ac
contrib
doc
src

> there is a similar symptom caused by an unrelated problem

> Subject: [PATCH v3] Avoid use of non-portable option ordering in
>  command_checks_all().

On a glibc system, "env POSIXLY_CORRECT=1 make check ..." tests this.