Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMtho-0005jZ-Q0 for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 14:32:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lMthn-0000XZ-Ea for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 14:32:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMthn-0000XS-85 for pgsql-hackers@lists.postgresql.org; Thu, 18 Mar 2021 14:32:55 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMthl-000834-5H for pgsql-hackers@postgresql.org; Thu, 18 Mar 2021 14:32:54 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1lMtFg-000511-2W; Thu, 18 Mar 2021 10:03:52 -0400 Date: Thu, 18 Mar 2021 10:03:52 -0400 From: Bruce Momjian To: Thomas Munro Cc: Paul Guo , Fujii Masao , Tom Lane , Michael Brown , pgsql-hackers Subject: Re: fdatasync performance problem with large number of DB files Message-ID: <20210318140352.GC8529@momjian.us> References: <823DAB20-5A5E-4F7B-BF8C-D61FA574DEEA@vmware.com> <76de0e61-a553-6003-aeec-cb35ada791cf@oss.nttdata.com> <52453bfc-40fb-7771-05ee-cbd04b6b9b6e@oss.nttdata.com> <4CB921E5-772B-42F9-B14D-D310E709E8F2@vmware.com> <20210318135411.GB8529@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318135411.GB8529@momjian.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Mar 18, 2021 at 09:54:11AM -0400, Bruce Momjian wrote: > On Thu, Mar 18, 2021 at 11:19:13PM +1300, Thomas Munro wrote: > > On Thu, Mar 18, 2021 at 8:52 PM Paul Guo wrote: > > > About the syncfs patch, my first impression on the guc name sync_after_crash > > > is that it is a boolean type. Not sure about other people's feeling. Do you guys think > > > It is better to rename it to a clearer name like sync_method_after_crash or others? > > > > Works for me. Here is a new version like that, also including the > > documentation change discussed with Fujii-san, and a couple of > > cosmetic changes. > > Are we sure we want to use the word "crash" here? I don't remember > seeing it used anywhere else in our user interface. I guess it is > "crash recovery". Maybe call it "recovery_sync_method"? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.