Date: Fri, 19 Mar 2021 11:35:11 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	David Steele <david@pgmasters.net>,
	Ildus Kurbangaliev <i.kurbangaliev@gmail.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [HACKERS] Custom compression methods
Message-ID: <20210319163511.GL11765@telsasoft.com>
References: 
 <CAFiTN-snEyq1QG5TgkoQeVyCvJHqw5m5Nq416ZpPcs372Z-4Gw@mail.gmail.com>
 <20210312103650.GR8796@telsasoft.com>
 <CAFiTN-s8SsWs2zCZL3TFxXwi4VE35J=4aKpduKVrTaL+3wnB0A@mail.gmail.com>
 <CA+TgmobRynuR8n18ZyUD4pA-T3tnPk+AME9=bg=jT4s_Uxk22Q@mail.gmail.com>
 <20210315225835.2toe2ceanp7gi6fw@alap3.anarazel.de>
 <CA+Tgmoam+QEwM2=9zfju6Mnc-7499vrtEKX+31w8HwKOOSKvAg@mail.gmail.com>
 <CAFiTN-sBH65e4B5kQB5MT8BQOPajkrKvSdKA-07+ra3f2x4vCA@mail.gmail.com>
 <CAFiTN-tErP5x54pvkZP7yLVJhpNBOZcd5TN_k1BDhjYCA9D0VQ@mail.gmail.com>
 <CA+TgmoYRsapWz2vDSQXFAEL_BAMq1aY37avcq9GAB=SUUvFhaw@mail.gmail.com>
 <CAFiTN-t03PqWCaRW1GoWQa0i2NwYw_p=FDj+Kxu_-rY_viALqw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFiTN-t03PqWCaRW1GoWQa0i2NwYw_p=FDj+Kxu_-rY_viALqw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210319163511.GL11765%40telsasoft.com>
Precedence: bulk

I sent offlist a couple of times but notice that the latest patch is missing
this bit around AC_CHECK_HEADERS, which apparently can sometimes cause
warnings on mac.

ac_save_CPPFLAGS=$CPPFLAGS
CPPFLAGS="$LZ4_CFLAGS $CPPFLAGS"
AC_CHECK_HEADERS(lz4/lz4.h, [],
     [AC_CHECK_HEADERS(lz4.h, [], [AC_MSG_ERROR([lz4.h header file is required for LZ4])])])
CPPFLAGS=$ac_save_CPPFLAGS                                                                                                                                                                                                 

> diff --git a/configure.ac b/configure.ac
> index 2f1585a..54efbb2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1410,6 +1425,11 @@ failure.  It is possible the compiler isn't looking in the proper directory.
>  Use --without-zlib to disable zlib support.])])
>  fi
>  
> +if test "$with_lz4" = yes; then
> +  AC_CHECK_HEADERS(lz4/lz4.h, [],
> +       [AC_CHECK_HEADERS(lz4.h, [], [AC_MSG_ERROR([lz4.h header file is required for LZ4])])])
> +fi
> +
>  if test "$with_gssapi" = yes ; then
>    AC_CHECK_HEADERS(gssapi/gssapi.h, [],
>  	[AC_CHECK_HEADERS(gssapi.h, [], [AC_MSG_ERROR([gssapi.h header file is required for GSSAPI])])])