Date: Fri, 19 Mar 2021 20:10:54 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Hannu Krosing <hannuk@google.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Michael Paquier <michael@paquier.xyz>,
	torikoshia <torikoshia@oss.nttdata.com>,
	Atsushi Torikoshi <atorik@gmail.com>,
	Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Evgeny Efimkin <efimkin@yandex-team.ru>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Feature improvement: can we add queryId for
 pg_catalog.pg_stat_activity view?
Message-ID: <20210320001054.GA7968@momjian.us>
References: <20210317223216.GE16650@momjian.us>
 <20210317232956.veah6bax3mespdtq@nol>
 <20210318134729.GA8529@momjian.us>
 <20210318180656.3aat6jkbs7ylcg4k@nol>
 <20210318192349.GD3721@momjian.us>
 <20210319031650.aqy3ad7fpqsudo3b@nol>
 <20210319132906.GG3572@momjian.us>
 <20210319142751.vsvsjbp4bsvbh4ek@nol>
 <20210319165443.GI3572@momjian.us>
 <CAMT0RQR10q0RJNHARtzPr-S_dDAX8us1zcbiQBx8YuuRAeYXAg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAMT0RQR10q0RJNHARtzPr-S_dDAX8us1zcbiQBx8YuuRAeYXAg@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210320001054.GA7968%40momjian.us>
Precedence: bulk

On Sat, Mar 20, 2021 at 01:03:16AM +0100, Hannu Krosing wrote:
> It would be really convenient if user-visible serialisations of the query id
> had something that identifies the computation method.
> 
> maybe prefix 'N' for internal, 'S' for pg_stat_statements etc.
> 
> This would immediately show in logs at what point the id calculator was changed

Yeah, but it an integer, and I don't think we want to change that.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.