Date: Sat, 20 Mar 2021 16:23:02 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	David Steele <david@pgmasters.net>,
	Ildus Kurbangaliev <i.kurbangaliev@gmail.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] Custom compression methods (mac+lz4.h)
Message-ID: <20210320212302.GW11765@telsasoft.com>
References: <20210315225835.2toe2ceanp7gi6fw@alap3.anarazel.de>
 <CA+Tgmoam+QEwM2=9zfju6Mnc-7499vrtEKX+31w8HwKOOSKvAg@mail.gmail.com>
 <CAFiTN-sBH65e4B5kQB5MT8BQOPajkrKvSdKA-07+ra3f2x4vCA@mail.gmail.com>
 <CAFiTN-tErP5x54pvkZP7yLVJhpNBOZcd5TN_k1BDhjYCA9D0VQ@mail.gmail.com>
 <CA+TgmoYRsapWz2vDSQXFAEL_BAMq1aY37avcq9GAB=SUUvFhaw@mail.gmail.com>
 <CAFiTN-t03PqWCaRW1GoWQa0i2NwYw_p=FDj+Kxu_-rY_viALqw@mail.gmail.com>
 <20210319163511.GL11765@telsasoft.com>
 <CA+TgmobuFsxf=nrweN7NYW9VMUV7dX4GYmN966kjeEgXxdxtrg@mail.gmail.com>
 <20210319174425.GM11765@telsasoft.com>
 <CA+TgmobXnzCRf-UOWnjk+OoCT-mzFR867HvoxM2N9uA7+_V-+g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmobXnzCRf-UOWnjk+OoCT-mzFR867HvoxM2N9uA7+_V-+g@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210320212302.GW11765%40telsasoft.com>
Precedence: bulk

On Fri, Mar 19, 2021 at 02:07:31PM -0400, Robert Haas wrote:
> On Fri, Mar 19, 2021 at 1:44 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > Working with one of Andrey's patches on another thread, he reported offlist
> > getting this message, resolved by this patch.  Do you see this warning during
> > ./configure ?  The latest CI is of a single patch without the LZ4 stuff, so I
> > can't check its log.
> >
> > configure: WARNING: lz4.h: accepted by the compiler, rejected by the preprocessor!
> > configure: WARNING: lz4.h: proceeding with the compiler's result
> 
> No, I don't see this. I wonder whether this could possibly be an
> installation issue on Andrey's machine? If not, it must be
> version-dependent or installation-dependent in some way.

Andrey, can you check if latest HEAD (bbe0a81db) has these ./configure warnings ?

If so, can you check if your environment is clean, specifically lz4.h - if
you've installed LZ4 from source, I have to imagine that's relevant.
Most users won't do that, but it should be a supported configuration, too.

-- 
Justin