Date: Mon, 22 Mar 2021 22:23:22 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: tsunakawa.takay@fujitsu.com,
	Andrey Lepikhov <a.lepikhov@postgrespro.ru>,
	Amit Langote <amitlangote09@gmail.com>, tanghy.fnst@fujitsu.com,
	Alexey Kondratov <a.kondratov@postgrespro.ru>,
	Michael Paquier <michael@paquier.xyz>,
	Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Etsuro Fujita <etsuro.fujita@gmail.com>,
	pgsql-hackers@postgresql.org,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	houzj.fnst@fujitsu.com
Subject: Re: [POC] Fast COPY FROM command for the table with foreign
 partitions
Message-ID: <20210323032322.GW4203@telsasoft.com>
References: 
 <TYAPR01MB2990D36AFD7A7AA70A81F116FE879@TYAPR01MB2990.jpnprd01.prod.outlook.com>
 <20210303202703.GI29832@telsasoft.com>
 <TYAPR01MB2990B8451B4C725242E270F7FE979@TYAPR01MB2990.jpnprd01.prod.outlook.com>
 <CALNJ-vTdEpeF0nzMhTPYJAhcZVdtwFN+YEkz4tn6p2gDG7j5sA@mail.gmail.com>
 <TYAPR01MB299090411AC25A6B56103869FE979@TYAPR01MB2990.jpnprd01.prod.outlook.com>
 <20210304203949.GQ29832@telsasoft.com>
 <TYAPR01MB29900C08C2C17747612A28B5FE969@TYAPR01MB2990.jpnprd01.prod.outlook.com>
 <e3974716-e77b-9006-b1dc-dc00474d09c3@postgrespro.ru>
 <TYAPR01MB29909FDCD92F5EEE68E37767FE649@TYAPR01MB2990.jpnprd01.prod.outlook.com>
 <CALNJ-vRi4DjjkCmvmXWWtULzY6PSeEAC9vSpXVNHyVoGEQ8HVQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CALNJ-vRi4DjjkCmvmXWWtULzY6PSeEAC9vSpXVNHyVoGEQ8HVQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210323032322.GW4203%40telsasoft.com>
Precedence: bulk

On Mon, Mar 22, 2021 at 08:18:56PM -0700, Zhihong Yu wrote:
> with data_dest_cb callback. It is used for send text representation of a
> tuple to a custom destination.
> 
> send text -> sending text

I would say "It is used to send the text representation ..."

>     struct PgFdwModifyState *aux_fmstate;   /* foreign-insert state, if
>                                              * created */
> +   CopyToState cstate; /* foreign COPY state, if used */
> 
> Since foreign COPY is optional, should cstate be a pointer ? That would be
> in line with aux_fmstate.

It's actually a pointer:
src/include/commands/copy.h:typedef struct CopyToStateData *CopyToState;

There's many data structures like this, where a structure is typedefed with a
"Data" suffix and the pointer is typedefed without the "Data"

-- 
Justin