Date: Tue, 6 Apr 2021 19:49:07 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, takashi.menjo@gmail.com,
	Craig Ringer <craig@2ndquadrant.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	takashi.menjou.vg@hco.ntt.co.jp
Subject: Re: Remove page-read callback from XLogReaderState.
Message-ID: <20210406234907.GA19311@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+hUKGJ7ecf2xGVOwFBzk1gJzm82gAj6rw0LrMtgoaS7_D5-aA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210406234907.GA19311%40alvherre.pgsql>
Precedence: bulk

On 2021-Apr-07, Thomas Munro wrote:

> On Wed, Apr 7, 2021 at 11:18 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > BTRW it's funny that after these patches, "xlogreader" no longer reads
> > anything.  It's more an "xlog interpreter" -- the piece of code that
> > splits individual WAL records from a stream of WAL bytes that's caller's
> > responsibility to obtain somehow.  But (and, again, I haven't read this
> > patch recently) it still offers pieces that support a reader, in
> > addition to its main interface as the interpreter.  Maybe it's not a
> > totally stupid idea to split it in even more different files.
> 
> Yeah, I like "decoder", and it's already called that in some places...

Yeah, that works ...

-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"Los trabajadores menos efectivos son sistematicamente llevados al lugar
donde pueden hacer el menor daño posible: gerencia."  (El principio Dilbert)