Date: Wed, 7 Apr 2021 22:42:29 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Nitin Jadhav <nitinjadhavpostgres@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Hannu Krosing <hannuk@google.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	torikoshia <torikoshia@oss.nttdata.com>,
	Atsushi Torikoshi <atorik@gmail.com>,
	Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Evgeny Efimkin <efimkin@yandex-team.ru>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Feature improvement: can we add queryId for
 pg_catalog.pg_stat_activity view?
Message-ID: <20210408024229.GJ24239@momjian.us>
References: <1646131.1617826550@sss.pgh.pa.us>
 <20210407202255.GD24239@momjian.us>
 <20210407215625.syzdpwew4j47hhgl@nol>
 <20210407223840.GE24239@momjian.us>
 <1730584.1617836485@sss.pgh.pa.us>
 <20210407233835.GF24239@momjian.us>
 <20210408004748.mhqds3v3nij35ihw@nol>
 <20210408005402.GG24239@momjian.us>
 <20210408023101.GI24239@momjian.us>
 <20210408023808.gp75kbrli5df7wkd@nol>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210408023808.gp75kbrli5df7wkd@nol>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210408024229.GJ24239%40momjian.us>
Precedence: bulk

On Thu, Apr  8, 2021 at 10:38:08AM +0800, Julien Rouhaud wrote:
> On Wed, Apr 07, 2021 at 10:31:01PM -0400, Bruce Momjian wrote:
> > On Wed, Apr  7, 2021 at 08:54:02PM -0400, Bruce Momjian wrote:
> > > > Unless I'm missing something this will output the query id in the next log
> > > > line?  The new code should be added before the newline is output, and the comma
> > > > should also be output before the queryid.
> > > 
> > > Yes, correct, updated patch attached.
> > 
> > Patch applied.
> 
> Thanks!  And I agree with using query_id in the new field names while keeping
> queryid for pg_stat_statements to avoid unnecessary query breakage.

I think we need more feedback from the group.  Do people agree with the
idea above?  The question is what to call:

	GUC compute_queryid
	pg_stat_activity.queryid
	pg_stat_statements.queryid

using "queryid" or "query_id", and do they have to match?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.