Date: Thu, 8 Apr 2021 16:30:51 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: yuzuko <yuzukohosoya@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	David Steele <david@pgmasters.net>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Daniel Gustafsson <daniel@yesql.se>,
	Amit Langote <amitlangote09@gmail.com>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	pgsql-hackers@lists.postgresql.org, Greg Stark <stark@mit.edu>
Subject: Re: Autovacuum on partitioned table (autoanalyze)
Message-ID: <20210408213051.GL6592@telsasoft.com>
References: <20210408032235.GA6842@alvherre.pgsql>
 <20210408052014.GA28806@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210408052014.GA28806@alvherre.pgsql>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210408213051.GL6592%40telsasoft.com>
Precedence: bulk

On Thu, Apr 08, 2021 at 01:20:14AM -0400, Alvaro Herrera wrote:
> On 2021-Apr-07, Alvaro Herrera wrote:
> 
> > OK, I bit the bullet and re-did the logic in the way I had proposed
> > earlier in the thread: do the propagation on the collector's side, by
> > sending only the list of ancestors: the collector can read the tuple
> > change count by itself, to add it to each ancestor.  This seems less
> > wasteful.  Attached is v16 which does it that way and seems to work
> > nicely under my testing.
> 
> Pushed with this approach.  Thanks for persisting with this.

commit 0827e8af70f4653ba17ed773f123a60eadd9f9c9
|    This also introduces necessary reloptions support for partitioned tables
|    (autovacuum_enabled, autovacuum_analyze_scale_factor,
|    autovacuum_analyze_threshold).  It's unclear how best to document this
|    aspect.

At least this part needs to be updated - see also ed62d3737.

doc/src/sgml/ref/create_table.sgml-    The storage parameters currently
doc/src/sgml/ref/create_table.sgml-    available for tables are listed below.
...
doc/src/sgml/ref/create_table.sgml:    Specifying these parameters for partitioned tables is not supported,
doc/src/sgml/ref/create_table.sgml-    but you may specify them for individual leaf partitions.

-- 
Justin