Date: Thu, 8 Apr 2021 17:56:25 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: yuzuko <yuzukohosoya@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	David Steele <david@pgmasters.net>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Daniel Gustafsson <daniel@yesql.se>,
	Amit Langote <amitlangote09@gmail.com>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	pgsql-hackers@lists.postgresql.org, Greg Stark <stark@mit.edu>
Subject: Re: Autovacuum on partitioned table (autoanalyze)
Message-ID: <20210408215625.GA17048@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="W/nzBZO5zC0uMSeA"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210408213051.GL6592@telsasoft.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210408215625.GA17048%40alvherre.pgsql>
Precedence: bulk


--W/nzBZO5zC0uMSeA
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2021-Apr-08, Justin Pryzby wrote:

> commit 0827e8af70f4653ba17ed773f123a60eadd9f9c9
> |    This also introduces necessary reloptions support for partitioned tables
> |    (autovacuum_enabled, autovacuum_analyze_scale_factor,
> |    autovacuum_analyze_threshold).  It's unclear how best to document this
> |    aspect.
> 
> At least this part needs to be updated - see also ed62d3737.
> 
> doc/src/sgml/ref/create_table.sgml-    The storage parameters currently
> doc/src/sgml/ref/create_table.sgml-    available for tables are listed below.
> ...
> doc/src/sgml/ref/create_table.sgml:    Specifying these parameters for partitioned tables is not supported,
> doc/src/sgml/ref/create_table.sgml-    but you may specify them for individual leaf partitions.

Ah, thanks for pointing it out.  How about the attached?

This new bit reads weird:

+    Most parameters are not supported on partitioned tables, with exceptions
+    noted below; you may specify them for individual leaf partitions.


Maybe "Most parameters are not supported on partitioned tables, with
exceptions noted below; you may specify others for individual leaf
partitions."

-- 
Álvaro Herrera                            39°49'30"S 73°17'W

--W/nzBZO5zC0uMSeA
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-document-reloptions-for-partitioned-tables.patch"

From 37a829ec7b9c46acbbdb02f231288e39d22fcd04 Mon Sep 17 00:00:00 2001
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Thu, 8 Apr 2021 17:53:22 -0400
Subject: [PATCH] document reloptions for partitioned tables

---
 doc/src/sgml/ref/create_table.sgml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
index 44e50620fd..3cf355cc8d 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -1369,8 +1369,8 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
     If a table parameter value is set and the
     equivalent <literal>toast.</literal> parameter is not, the TOAST table
     will use the table's parameter value.
-    Specifying these parameters for partitioned tables is not supported,
-    but you may specify them for individual leaf partitions.
+    Most parameters are not supported on partitioned tables, with exceptions
+    noted below; you may specify them for individual leaf partitions.
    </para>
 
    <variablelist>
@@ -1452,6 +1452,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
      If true, the autovacuum daemon will perform automatic <command>VACUUM</command>
      and/or <command>ANALYZE</command> operations on this table following the rules
      discussed in <xref linkend="autovacuum"/>.
+     This parameter is supported on partitioned tables.
      If false, this table will not be autovacuumed, except to prevent
      transaction ID wraparound. See <xref linkend="vacuum-for-wraparound"/> for
      more about wraparound prevention.
@@ -1576,6 +1577,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
      <para>
       Per-table value for <xref linkend="guc-autovacuum-analyze-threshold"/>
       parameter.
+     This parameter is supported on partitioned tables.
      </para>
     </listitem>
    </varlistentry>
@@ -1591,6 +1593,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
      <para>
       Per-table value for <xref linkend="guc-autovacuum-analyze-scale-factor"/>
       parameter.
+     This parameter is supported on partitioned tables.
      </para>
     </listitem>
    </varlistentry>
-- 
2.20.1


--W/nzBZO5zC0uMSeA--