Date: Thu, 8 Apr 2021 22:17:18 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] force_parallel_mode and GUC categories
Message-ID: <20210409031718.GO6592@telsasoft.com>
References: 
 <CAN0SRDFV=Fv0zXHCGbh7gh=MTfw05Xd1x7gjJrZs5qn-TEphOw@mail.gmail.com>
 <CAFj8pRDycZjBLBaEkUcY4B01PS=ojoaBgQnzJaqBROTn8KM7Bg@mail.gmail.com>
 <20210403141651.GI6592@telsasoft.com>
 <CAN0SRDF6ZzxV-+OdgP6B+Zg0TmhrYFSOd3kK8GC5mkfo1icEGQ@mail.gmail.com>
 <20210403151201.GD29125@momjian.us>
 <3972636.1617464359@sss.pgh.pa.us>
 <20210403154114.GJ6592@telsasoft.com>
 <20210403154336.GG29125@momjian.us>
 <20210404012546.GK6592@telsasoft.com>
 <YG+y/eJErKPDUhiS@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YG+y/eJErKPDUhiS@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210409031718.GO6592%40telsasoft.com>
Precedence: bulk

On Fri, Apr 09, 2021 at 10:50:53AM +0900, Michael Paquier wrote:
> On Sat, Apr 03, 2021 at 08:25:46PM -0500, Justin Pryzby wrote:
> > Forking this thread
> > https://www.postgresql.org/message-id/20210403154336.GG29125%40momjian.us
> 
> Didn't see this one, thanks for forking.
> 
> -       {"force_parallel_mode", PGC_USERSET, QUERY_TUNING_OTHER,
> +       {"force_parallel_mode", PGC_USERSET, DEVELOPER_OPTIONS,
> And not this one either, as it is mainly a planner thing, like the
> other parameters in the same area.

This is the main motive behind the patch.

Developer options aren't shown in postgresql.conf.sample, which it seems like
sometimes people read through quickly, setting a whole bunch of options that
sound good, sometimes including this one.  And in the best case they then ask
on -performance why their queries are slow and we tell them to turn it back off
to fix their issues.  This changes to no longer put it in .sample, and calling
it a "dev" option seems to be the classification and mechanism by which to do
that.

-- 
Justin

ps, Maybe you saw that I'd already resent without including the accidental junk
hunks.