Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUyUI-0004fg-Q1 for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Apr 2021 21:16:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lUyUH-000790-Mm for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Apr 2021 21:16:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUyUG-00078t-Ku for pgsql-hackers@lists.postgresql.org; Fri, 09 Apr 2021 21:16:21 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUyUE-0004c9-4U for pgsql-hackers@lists.postgresql.org; Fri, 09 Apr 2021 21:16:20 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 63A6D5C00CA; Fri, 9 Apr 2021 17:16:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 09 Apr 2021 17:16:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=8uTJdbrjfxr6Tqo22H6CNVX1sqXksfw5YrZGvfnnvFw=; b=gVo5Jm4d f5eHnf6iP/Lvt+VFkHBmSbyAi5Ua0jyz4IEf+/O2HviIqrdBkdmkpAyO59s2HMwH rXVogoUCPHtbJCn4cRtW0W9S4misCZwmJNs3gNMgTDdJaGLPhAV3+qwiiPOXqi4r 6T7dpRpRUs6sHj88gnwY17CJQlVUKVPMuypWm03PihfAOfcj72umdKr+C5ZBpKj0 0t3yNDyp9D07HGKL+VDmABLBLWTzrmqeWgPiH+5ko2UhiuHXvnTsvhgyAfEJks/e Vy27tVv/61yu4o62TFRl/jk7a/h3ewntunlW5bRkgU9k8Xe9B/wYc8O8iTZeV5kJ J5L23MLa6csqPg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekuddgudeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggugfgjfgesth ekredttderudenucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghr rhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepueffhfejie euueffgedvudekgeeltdeviedvieeufeeiieevgfetheeufeethedvnecukfhppeduledt rdelhedrudelrdelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.95]) by mail.messagingengine.com (Postfix) with ESMTPA id 65552240054; Fri, 9 Apr 2021 17:16:14 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id B1A1B2A0EDC; Fri, 9 Apr 2021 17:16:11 -0400 (-04) Date: Fri, 9 Apr 2021 17:16:11 -0400 From: Alvaro Herrera To: Tom Lane Cc: Kyotaro Horiguchi , iwata.aya@fujitsu.com, tsunakawa.takay@fujitsu.com, k.jamison@fujitsu.com, pgsql-hackers@lists.postgresql.org Subject: Re: libpq debug log Message-ID: <20210409211611.GA23762@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3928040.1617404844@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Apr-02, Tom Lane wrote: > Alvaro Herrera writes: > > On 2021-Apr-02, Tom Lane wrote: > >> +1, but the comment could be more specific. Maybe like "In regress mode, > >> suppress the length of ErrorResponse and NoticeResponse messages --- the F > >> (file name) field, in particular, can vary in length depending on compiler > >> used." > > > With your commit this is no longer true, so how about the attached? > > Right. Your text looks fine. Pushed now. -- Álvaro Herrera 39°49'30"S 73°17'W "I'm always right, but sometimes I'm more right than other times." (Linus Torvalds)