Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lW8Y1-0006iB-Ke for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Apr 2021 02:13:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lW8Y0-0000Ze-IC for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Apr 2021 02:13:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lW8Y0-0000ZX-7A for pgsql-hackers@lists.postgresql.org; Tue, 13 Apr 2021 02:13:00 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lW8Xy-0008Ec-2s for pgsql-hackers@lists.postgresql.org; Tue, 13 Apr 2021 02:12:59 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1lW8Xm-0008Dn-Ry; Mon, 12 Apr 2021 22:12:46 -0400 Date: Mon, 12 Apr 2021 22:12:46 -0400 From: Bruce Momjian To: Alvaro Herrera Cc: Julien Rouhaud , Tom Lane , Nitin Jadhav , Hannu Krosing , Robert Haas , Pavel Stehule , Michael Paquier , torikoshia , Atsushi Torikoshi , Tatsuro Yamada , Tomas Vondra , Evgeny Efimkin , PostgreSQL Hackers Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? Message-ID: <20210413021246.GD4231@momjian.us> References: <20210408153425.GC2439@momjian.us> <20210408165106.GA8261@alvherre.pgsql> <20210408170142.GB6909@momjian.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210408170142.GB6909@momjian.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Apr 8, 2021 at 01:01:42PM -0400, Bruce Momjian wrote: > On Thu, Apr 8, 2021 at 12:51:06PM -0400, Álvaro Herrera wrote: > > On 2021-Apr-08, Bruce Momjian wrote: > > > > > pg_stat_activity.queryid is new, but I can imagine cases where you would > > > join pg_stat_activity to pg_stat_statements to get an estimate of how > > > long the query will take --- having one using an underscore and another > > > one not seems odd. > > > > OK. So far, you have one vote for queryid (your own) and two votes for > > query_id (mine and Julien's). And even yourself were hesitating about > > it earlier in the thread. > > OK, if people are fine with pg_stat_activity.query_id not matching > pg_stat_statements.queryid, I am fine with that. I just don't want > someone to say it was a big mistake later. ;-) OK, the attached patch renames pg_stat_activity.queryid to 'query_id'. I have not changed any of the APIs which existed before this feature was added, and are called "queryid" or "queryId" --- it is kind of a mess. I assume I should leave those unchanged. It will also need a catversion bump. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion. --mP3DRpeJDSE+ciuQ Content-Type: application/gzip Content-Disposition: attachment; filename="query_id.diff.gz" Content-Transfer-Encoding: base64 H4sICH/8dGAAA3F1ZXJ5X2lkLmRpZmYA7Vp5c9vIsf9b/BRtv8qKkkiI9+ErK2u5ftyyZUek skk2WygQGJKIQYCLAXXY6+/+unsGIEACJO3sSzlVlsvEAOjpmelrft0Dx51OoVqduRFY505g n8sQ/88W3vki8N0oCF1/ZtA9THa+Lrm+I+6h1+h1273utFM3jFZ74rT7jWbThnqt1mm1StVq dc8opbOzs30jff89VPv1fqULZ+qCD5aBjGahkADQ6Nb6TYCaUdM/zVqt36Hn7Qb8GfTfiEjr 9SfNFl5rT2q1hMUTkCIsQYnJnoXB3QvVhGfCj8IHCANPPH9sW5HlBTMzsiaeMPnN4xfPllZo xQSBt1r4piOmLk7fDfzHL0pVzUhG4cqOpq7wnBe/rUT44DrPztMP4Vn0sBQvJu7M9aNn53xT OivqbR7UXfc+pzkmd+kbGDq4DhdZhBBMIZq7EiaW/V74zrGEBYoHQmEjCfCoBgynJSdtPqQx 3eFcy+dcPshILMxbV9xJQ/5GZnQImTanVrvuTBpC1Cw0p0mvNq3Vu/UNczqInTKrg0jJvHrN JpmXuuCDy+vBxXgAfx0OfoblzJSRFZmWHbm3bvQAF6NYgNq0DHovKptP9cjmvetsvJPrdwvX r8R2EnfUJlKJLSDz3Nzipl8Ujk/moN79eP32TbKemVivqXx18/r1Ca4MRsUqFvfCXqFjcuON 5fqGvSHjHAqtWFRqw5n2ut2mYbR7/YbdnPQanWLF5nHa1mkeFamz3qxX6nU401d8NNCUo8gK o/JfSF4/CGnD6W9xswLoOyCmnjWTJyX4WIKj81P8gVMY+iCDhQDbkhhxysKYGWD5MPjb4PIG rYS1v0A/OQFLuQqoiWEQgDvX80C+d5elKrFC/5MCO1veg3RlBe7mrj2HhbB8iQ5oRfgjQOsf 7gL/OIKJQDdcBmEkHAPgKoiEYsXkboSuOrfChSckcgg0aYbNYuVF7tITELkLUQFL8lvbwonR 7BQ3HMWd+UEoHHCnTBAFS/DErfASRnPsanmhsJwHpBf+el6ls89bnLlrdWeHr848YHlnBy3P 3L0+soNzlNRyxr6jXphaMOXEiKovlp7l+8KR0SKqqmg9dCowtTwpTp7iXHIYmJ/DAfepI1xB OWPQ5jwI3qPRHh2VT3NeQDll5drCnx7o5+9ww/A84e329TVVHMinttXr9hqThmF0Oz2n1m21 W80D/T3FbY/PpyjZ77ttCuPqor1+JELX8twP4h3KtUw/cEoirsBgRI4Lp4Id+ETrGI6WJHp4 DgvrvbgKHMGdUCMjfEwaUATVF3awWFi+M8bwitSXb34wR4PXg8vxU7KTjPrwtdY7Bd3FQ2I4 yiQOoDUVcTI2muq1iFahjygJe7B1ZF+/CVDBD/j6EkPUNoVt+SMRjS3qjUhC7LAHduvwnP36 g9gyhM3X2gL603qz16s59b5hWJbVafSn/daOiL/FZlv1WyQq1jdY53whZEhEpqYpX1t3pDZU OT0ehwIjhB34CG1sjCtwKoNVaIuxuI8q7FpTpDCZlo2ivFS2QX630/k/29cLXDtkpaqQhE8+ abOuK7Ou5yzRvLVCQnUL+d+/2EITjOxgeR4D9i0L3HibpCbtqdNu12tdw6g36h2rMWn2u8UG uMll2/42KUg3nX6LdKMupJtZohiMDSiOu9CNWMrbGopIQ1+FJmhHoexGeRjjQ8n7yWge3N1I aybKj99dXI8GcHF18frvoyECxfHFeDgaDy9Hj5EJm2mtqexUXfERhWhTugvcndU8ymlzVDPD PAaDFA+GG1R0jRmHe4sZyWmoWxS0jhCb1TtHR9MgXFiREkuBXGoVjmcsiSJRrGlo8QrnEUp4 JRS20JEdfAtRH44JK8Q1rs9IbyXBcSXuIA9QJjv1ZIBgAXsIBh7FNox40JPnMeKOH5uK55ZN 76HWNt6p12v1elO0O4bRxDRc9Cyn0Si28X1ct21+Xw9SfLvFPqAu7ANpqSc5xkvVV+26KmXK hCd7QXxDNoUjwl8R2atcc6BRkSHhPGwtlrh11dg6UIPI0LxHwi0a0uOd5UYmYj0/Ml1/GoAV CqU41CTl847a+LOj5nLjEasblDE+fg43w6txp3X59mo0LteUCW5TmrmkNPwyDBAAbs42WeW7 V+R05uDqB/Pn6+F4YF5cjod/HY7/XtZjKDZq0+jUGAupyx+iFHQQN6kYGAlcotjBHeH5c44K A/P65upqePXqhCR1sKAOlZMeUk8MHj0HTl7x8Ue18Hqv0mzgytX1j1j6JxoVbayq/zBhP4X8 8HMCVUzbc9+a+jXAKf2HS4KuDqU1q6VDc8CUpJpKSbLShtTwwJK/DVynVM2fxgoDZqcFSbCf BIFHkcxGnHtWMLddfTgfvg08C8OBgHezlOwwIJ5q3aG63jy8HAyorTSFoZXTS0q6QuwTS9/F aOnKxP8qkLIOOQ9WnpNkYnPrVnA6pjK5gzmZu1ixNeMuLqKMHT+KF/L77/BIi2lzNI5PCrpk 1/izgMD3HtJJarFGJWa74znZHSel8dpdqVb5b/MyFbP1OjEbx4zWiit8nCDLItfIunEFglBx unOjOZU+xP3Sc23c4jjNRgvm4uF05dtc9FhJSkto0mw+QCknznHImbfiJFEVztZKSJN+EMEH EQaY/adrB1wLoHfWWhKKld6tUfOBTvJ56MAXgAH1Frk7sPK5hMBMcuaflhP13Y5zVbaPvGCG AagG330Hj2L3yqc0c0i3DYkDWJszGnXZCl+HeDivRvhypUWBElqi34bgBEJS1YVMHLWGGSZg Mi3WwVxvMS8Hr4ZXxZtMtSCq68lQOC+I5gkFHLabUeRV2LLRqNQbBC5VYy0XSpPt0JJz4Zgx PEkMmWp6SxfFo0L6ZDWdilCV+rDtCT8numfj+2bGno3vWzl6Kr6rBB0FHIZURF+X1nOjO0pf qTQJ6RsjU7hfB+/NgdVbDtMcyJI4nLIywhEaqHc1UO9mTCx3RDamvKKxru+566IZulsk7Iii MILmaRgs2PwkwmjFJg4+68pgUhhEU00qgrgLx1Lj9GnthHohyerSBkhmV/zeJAKl670Y3YnO lUQoohVi800qjcnrvcak3hbNaYMwuT3tNkSvt+MMo4hbIRbfolQHZK1KvUYnZHxVmeh2nf/d K/PHmyt0tLdX5sX1q5EC20e3lrcS8pdG91f00ZcYSTAT+gG39kVZZ4mEsF+NRjDw7fBhyUGe YrHrq/7JH+qYciUNpz8xVC4KnAgXaycMkQsDpiLhIfwV7le/NPq/JgUreixwdjxIsgQmuBmS JyWLyBldg/PP62ZyP4bYoMfG68d99iTCkOqVmGAXmFKaQFuRVRcTUes47YlhdNq1er/f69vT fVaUYVRkQBkisp1Gt95l44kb+JCqAZ7rC3MZiql7Xx5xmj6kfAQDZwUGxATFZMGpQPBqKS3R CQkc/+X4idIZ6XVpOQ6hgUdrVR5ZyyWDx5hlmVk+/tOp5zmPK6C7VJRi8a/sBciBfk6KwnKs z/3UpibnqcQ63DEpntN/YCoTjKHvVdsRU2vlRVqK6Hqq7gGsOajGKAfNDR2NNdjvcETXV3yk yk62vEVFlvOUtbncS9wgy9/xmo8rxycxIkk2KxV/t4T0XVpKcKh0/j02idj2LOOfvlrHHvdc uNI+Z8b/Wi0whyhw0m0y7artZqPXmUyazaZhWFOn43Q7tpjsc9UcdkUOm0NKSm/yJxFN9UUE CeN/+OMDAT/dvHn5emCOhv8YkP0gZGqtNSn1eYjFQVwBIpDuBxW0S1WStmtrLMLIEQGiSROh CkysxkxZOdKISinHC2zmnXmGQAv1fgBv80uZg2ZOoAUu2Cp+YmmV1UUf9vwrPqvX+5Uaa+VL 9CnME9Sg6DqLCoxIKCSZTe6KIR8i44YhQt/ycgcBJtGFTl0k7bOf9rWXpjiV08TZQgQ/isR9 RH6bMxCoEshTjf10oVeLlU+tuDiCISxbA8Z+RfpNhqxQLDusm5ntlwEGoFnQ4dNaibtolFJ1 MaveVAd7zfaXyo3qLWrSySF9Ku2kGi8h1Zl7i0myXlXsMBxbYoyeMeFS9RD/UMJhoRxgyaWz g/ziM5lyYpBNGUm6GU/7zcs5BHR921s5Ivl8BlElVSkN3EZ0rNpBoQPktNVvdzvtpiXoKLA3 mTrTft5XPbs4rWPjLiquRjd6qhytrhQagTITTA0iPqp9AcehsIPQOa7Qcyuc0XPJL1BCreOK 7mF5XublR3pbwQhQSRqsgNyfuGQcfTiojXFb92Te9M3QfcyfUvsUaybglr9aYDS3N6m4xVT4 0/u0Xk84WwROsphK8OX/iGk1ZkrHJJop5dqoCPylFqYC8kFiA3dpz1WmaRJ1RQVI5bOpejfJ OnVfWdfgK/FpEbVTpxB4x7xMNGJ/Jiq25xIjRJBh3J4HMuJB9T2VURIWJOTMx1jpr6YqUnr0 /1aEkrwKm7a7xFyVWhM3knQ1NVvHT9+pbZafuFLi3On9TErTWkVzbiwxrNjcEnj1MIFGIpKa jiEk4rNvIv7/E7GpZKx8AyMLizcvaz6GT0j2EWjvJ5pms95THdGZ7JCf8b4gcWuQT4BObQiv E8CyJsEqogHozFjSd5Z69RLClc+fbywsdFPhW76dnDwi98JIrDDhxkHcfCM45hPFJ+Oi3upP 2h3bMox2s+9MRatV6xXH4wJm2yG5gJB3cJWg1OP8hHSPcBXUZ6ybJwqEZGivOjrC1DsWnjpE /0XXDa9u3pjvrt++uh6MRua7i+uLN79u5Szx/l6BgGsWGNAfYuzi6Co1neeb2S8q6KMple6s 1rNIFZk2n+rS0uYieDo6PcO0ukXpGV/5ZJxwo4KTOsOx0T7DrQqmKX1rKedBpKpxT3Wt8iKu wamqMC0krr5Lxik5A3zp+dfTUrWY2wHlaBTZnv57Tp+e7loOQvXl1EWYT0jdjIDaMWjfIYTl kuJVBlLpZ7s7crhMNu7yOG6NP0DEjVT3NPNUGhurWJc4c4rVvHZ7Luz3Nxjk9nP8zPL3Zs0O 0vXwtba1RnbUhteaLaY118SwXWjfinIRivM8FOzw5+J+yeXk83CFSjUokk4OoUoqsR3Rsfud jm0YzVav1xJOuym249w+butAt49Sfa3VaXA1LW6karGxYn4H9akgSENt5SX9XXj6S3KZ8wV5 7pfjcuOLcbn5pbjMfCEus1+GV+MPw8vlwk/DnzyhLWqGtgiyrGas7CqBH7CFP+KQohOzTQiS elCBFAiBNAqBLAyBDA6BNBCBTSQCaSgCaUlCRoSQQSNAcARSeATWgARiRAJZSALbmASyoAQS VAJrWAIxLoEUMIkPgk9Yk9/U8lWpxeTjMP57PfhxDD+9HV6Ra1NJdUKVbwfeXqG+tFPDc3AM inwnub1oYCRaxX1inWG3le6GITOJHB7OnKKakEnwsA2udY0QBHjk6xx9el0FtNQ1fQ4kpbV0 U5FnmYoPsSSIW9wm9ISWI7JULCUi44a7RLGmXwv1UqhzIuGsw8s3K/46rDgTXL4p5etQShxa fv7fwfUAMBqk1gLDEVy9HavP3FIhgU7mRGTPTapm4ezTqIK/4DX5g5bEPWN6FSgatXaPj4zU NRUoEOnGes2NFneGfPBtWlMQorlkn6YBzJ1BrB4YLn+DGV+f0X2DGV+lWlIwI8YKiV7uLA9H QRwQyvIJ3JW5lxa1pCl4EgdUh7/cnHorOVdNckbrIUNhzRIKasYU1M76OKScG9ZefRKDlyXj lju6/iFwJxWDTOkFkUzHNrxXRqYDWU8Hst5GIEM1FMCdjAoJr6z1mUOi1Joi03pOkybqJrLk 5hv6+dqc6xv6+QqV8iXoR64m0g7dZRamrOKUCF+v/X1l4K2KGP8HsyqINwBDAAA= --mP3DRpeJDSE+ciuQ--