Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1la0Sp-0002dJ-Gr for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Apr 2021 18:23:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1la0Sm-00050W-1A for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Apr 2021 18:23:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1la0Sl-00050P-QE for pgsql-hackers@lists.postgresql.org; Fri, 23 Apr 2021 18:23:35 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1la0Sg-0001CX-6x for pgsql-hackers@lists.postgresql.org; Fri, 23 Apr 2021 18:23:34 +0000 Received: by mail-il1-x130.google.com with SMTP id b17so41458576ilh.6 for ; Fri, 23 Apr 2021 11:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5CDqJQZGNL6YTOM8imoMSWdwMBblcSvf9KeOmET+EOk=; b=G+2zAlwDzRvMZPbOI7qH+kxAYqDPvs/Njc1R+NUlRjUDzMC1URuS1dXcT9lTzxv/xJ LcGzFa0RAOBvlOJAAmB3pkn8bdjnM7iRhxcOIwF6eMR0bMQhoAJNbbTkX09Xs/76XUTS fITVlrRSYrx+1uuzW2/rdU6C/R5urj24HcbpBNrXKHXkITGUluccWgvfn0SHIODL4F8m Hi1lGp7/LtU47uZ4wfXPW8PbLVQYv6dGSiZIr32O+L5FSaAsYXmPPBTzcd/zkRrzFxHc ttzeIB31bob0XzwDNmq1ZN79fvVCfxK2abmpEGbFVpo7kl9DZ4Cc3mP8px2NmMz5K6ry 5AsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5CDqJQZGNL6YTOM8imoMSWdwMBblcSvf9KeOmET+EOk=; b=UmLJSbEQ3NsJgVFooRWkxJin0Ws7SVTGMfIR3GeofWRPvUh2hvSzrA1zRSC7fbe5nN FoLCYpfFo3vTW0CIJUZbItUqJJsitqZS3DrvA+ph7YhDTEenwD3DS1CsMVFcqkuB72+f IoPZib5plhz1r7EhLT4PKIXKhrS6+Xx3KeXm4kQ+rEMkcxZM+WdpFCl/nyY7WvcY+MNv e3nmMWiCBf/2pOHaDk9pdwTivQ0gwKejL6emLxWvyVxKk4WCGeDtsLEmmmPM1ZUa3nAk AcBN18hFkvhrphK14XT0xCtS9vcjKqxJ7C+3mBL/QvofbWZdyuewJiGB5gwZxJT4DR6m WdSg== X-Gm-Message-State: AOAM530aBTSxQlvnwe/juT2rS2Iz1ywhHii0EIsYuMKs2iBLE+LVI2ot JeBGSrFEWxdlWrZQPqz6vgobRiBOfHHv6g== X-Google-Smtp-Source: ABdhPJzjNX/7nu5aHenCpMFi6jKZ2ADuJWg3cDuO3Nj7sGXUcGGQdsbKrLgLJTSXzuUGxdBq21myug== X-Received: by 2002:a92:d711:: with SMTP id m17mr4077493iln.12.1619202208753; Fri, 23 Apr 2021 11:23:28 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id m8sm2903900ilc.13.2021.04.23.11.23.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Apr 2021 11:23:27 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id F2DEE801553; Fri, 23 Apr 2021 13:23:26 -0500 (CDT) Date: Fri, 23 Apr 2021 13:23:26 -0500 From: Justin Pryzby To: Michael Paquier Cc: Tom Lane , Bruce Momjian , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] force_parallel_mode and GUC categories Message-ID: <20210423182326.GK7256@telsasoft.com> References: <20210403154336.GG29125@momjian.us> <20210404012546.GK6592@telsasoft.com> <20210409031718.GO6592@telsasoft.com> <20210409113928.GA12919@momjian.us> <2746080.1618206052@sss.pgh.pa.us> <20210413123139.GE6091@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Apr 14, 2021 at 03:57:21PM +0900, Michael Paquier wrote: > On Tue, Apr 13, 2021 at 07:31:39AM -0500, Justin Pryzby wrote: > > Good point. > > Thanks. I have used the wording that Tom has proposed upthread, added > one GUC_NOT_IN_SAMPLE that you forgot, and applied the > force_parallel_mode patch. Thanks. It just occured to me to ask if we should backpatch it. The goal is to avoid someone trying to use this as a peformance option. It's to their benefit and ours if they don't do that on v10-13 for the next 5 years, not just v14-17. The patch seems to apply cleanly on v12 but cherry-pick needs help for other branches... -- Justin