public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yugo NAGATA <[email protected]>
To: Yugo NAGATA <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Andy Fan <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Tatsuo Ishii <[email protected]>
Cc: Thomas Munro <[email protected]>
Subject: Re: Implementing Incremental View Maintenance
Date: Mon, 26 Apr 2021 16:03:48 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAKU4AWoxXkPPL2qMoAn-2skEbt+9E2MrARhcf+NKwm4JFg-uHg@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<ea935ebc-cd3f-7a8f-563c-33c9b6! [email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On Mon, 26 Apr 2021 15:46:21 +0900
Yugo NAGATA <[email protected]> wrote:
> On Tue, 20 Apr 2021 09:51:34 +0900
> Yugo NAGATA <[email protected]> wrote:
>
> > On Mon, 19 Apr 2021 17:40:31 -0400
> > Tom Lane <[email protected]> wrote:
> >
> > > Andrew Dunstan <[email protected]> writes:
> > > > This patch (v22c) just crashed for me with an assertion failure on
> > > > Fedora 31. Here's the stack trace:
> > >
> > > > #2 0x000000000094a54a in ExceptionalCondition
> > > > (conditionName=conditionName@entry=0xa91dae "queryDesc->sourceText !=
> > > > NULL", errorType=errorType@entry=0x99b468 "FailedAssertion",
> > > > fileName=fileName@entry=0xa91468
> > > > "/home/andrew/pgl/pg_head/src/backend/executor/execMain.c",
> > > > lineNumber=lineNumber@entry=199) at
> > > > /home/andrew/pgl/pg_head/src/backend/utils/error/assert.c:69
> > >
> > > That assert just got added a few days ago, so that's why the patch
> > > seemed OK before.
> >
> > Thank you for letting me know. I'll fix it.
>
> Attached is the fixed patch.
>
> queryDesc->sourceText cannot be NULL after commit 1111b2668d8,
> so now we pass an empty string "" for refresh_matview_datafill() instead NULL
> when maintaining views incrementally.
I am sorry, I forgot to include a fix for 8aba9322511.
Attached is the fixed version.
Regards,
Yugo Nagata
--
Yugo NAGATA <[email protected]>
Attachments:
[application/gzip] IVM_patches_v22e.tar.gz (83.3K, ../[email protected]/2-IVM_patches_v22e.tar.gz)
download
view thread (215+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Implementing Incremental View Maintenance
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox