Date: Mon, 26 Apr 2021 12:31:35 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <20210426163135.GU20766@tamriel.snowman.net>
References: <35457b09-36f8-add3-1d07-6034fa585ca8@oss.nttdata.com>
 <20210424152220.GL7629@momjian.us>
 <CABUevEx4YQi42MwaMq3Bo09=mBqfjUqtkp5NUZpnQ0HdX+5+Hw@mail.gmail.com>
 <20210424170908.GM7629@momjian.us>
 <1709439.1619286231@sss.pgh.pa.us>
 <e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com>
 <YIbdhrfemBnwAvl5@msg.df7cb.de>
 <20210426162104.GQ7629@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fBk6lrKHwE8t7bFK"
Content-Disposition: inline
In-Reply-To: <20210426162104.GQ7629@momjian.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210426163135.GU20766%40tamriel.snowman.net>
Precedence: bulk


--fBk6lrKHwE8t7bFK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Bruce Momjian (bruce@momjian.us) wrote:
> On Mon, Apr 26, 2021 at 05:34:30PM +0200, Christoph Berg wrote:
> > Re: Peter Eisentraut
> > > > Agreed.  If pg_stat_statements were zero-configuration today then
> > > > this would be an annoying new burden, but it isn't.
> > >=20
> > > I think people can understand "add pg_stat_statements to
> > > shared_preload_libraries" and "install the extension".  You have to t=
urn it
> > > on somehow after all.
> >=20
> > Fwiw, I'd claim that pg_stat_statements *is* zero-configuration today.
> > You just have to load the module (=3D shared_preload_libraries), and it
> > will start working. Later you can run CREATE EXTENSION to actually see
> > the stats, but they are already being collected in the background.
> >=20
> > > Now there is the additional burden of turning on this weird setting t=
hat no
> > > one understands.  That's a 50% increase in burden.
> > >=20
> > > And almost no one will want to use a nondefault setting.
> > >=20
> > > pg_stat_statements is pretty popular.  I think leaving in this requir=
ement
> > > will lead to widespread confusion and complaints.
> >=20
> > Ack, please make the default config (i.e. after setting shared_preload_=
libraries)
> > do something sensible. Having to enable some "weird" internal other set=
ting
> > will be very hard to explain to users.
> >=20
> > Fwiw, I'd even want to have pg_stat_statements enabled in core by
> > default. That would awesome UX. (And turning off could be as simple as
> > setting compute_query_id=3Doff.)
>=20
> Techically, pg_stat_statements can turn on compute_query_id when it is
> loaded, even if it is 'off' in postgresql.conf, right?  And
> pg_stat_statements would know if an alternate hash method is being used,
> right?

+1 on this approach.  I agree that we should avoid having to make every
new user and every user who is upgrading with pg_stat_statements
installed have to go twiddle this parameter.

Thanks,

Stephen

--fBk6lrKHwE8t7bFK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJghurnAAoJEO1sijiDR2RV1nMQAJOy0FC1SPARonuVUW+ca+cD
He00sP3VyaENUWBjqTLy0f9FNAWKPwQTCzjJ2/Ffyvvnymp5jr+ubqoqiLYezwui
sHCCQryn/NQ14p+IfVCIJm4fTn1MLwuHMKjLZ/u5LNDD4eDW7MxHwZoL4jnfcBYP
GGsVPynH99dQr6MNF8ZFBs76Hnk6lqn0EN42mDw1GcwFpjlfZQMDSwcy3p76VCKS
Ya2/LrdyDa/Uu6i9gH0bAfU4Qe+GYTgkgy/w6BqOlB2Nh/x81w1YufYqF+zyPBN8
4jPOlgLl2yS0gwBVzVHYFlRAITpOESAoXp7qLZ7wvpTp2jzJPjirCMXl+fj4knZz
6eSv66t+5Zl44vdr5lH6JuLEcpQHVHhoYxZPOedy9QEOi0oLiSh6mnopkxo6ZmVE
HVJwLVChGZrfzo/IAQwUVmo1m09VtPJPEvmvUKS+7Amn54xYeIG5zlpCfleeHHQW
CODztpBJlBvnU5AE/kA1kd/jaEDjFrleqBeMIY9aUYL7RAiK23uEBvNJRcQWuCwd
IVJI38HO5VVEvnloz89BCkVX7Y5veyDq6Y4J6E8Xv9UFOEdsE19C/2C8eEYQipRT
/7Z+EK/SJHDGxRvbkbsqvaq+rr1aC20enPzkVcCPC6Qfw34WGEtxf9lH6txpl9Sh
387N65ycIMuQiFR3pAup
=RLtM
-----END PGP SIGNATURE-----

--fBk6lrKHwE8t7bFK--