Date: Mon, 26 Apr 2021 13:43:32 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, Bruce Momjian <bruce@momjian.us>,
	Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <20210426174332.GY20766@tamriel.snowman.net>
References: <20210424170908.GM7629@momjian.us>
 <1709439.1619286231@sss.pgh.pa.us>
 <e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com>
 <YIbdhrfemBnwAvl5@msg.df7cb.de>
 <20210426162104.GQ7629@momjian.us>
 <20210426163135.GU20766@tamriel.snowman.net>
 <2267128.1619456173@sss.pgh.pa.us>
 <CABUevExH+nLxfYqbUYV3zB7QqaCrzxRAbnTrs0Dbt4f0W1Xn=A@mail.gmail.com>
 <20210426172354.GV20766@tamriel.snowman.net>
 <2268611.1619458140@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="uz98qLkXqquHDvSM"
Content-Disposition: inline
In-Reply-To: <2268611.1619458140@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210426174332.GY20766%40tamriel.snowman.net>
Precedence: bulk


--uz98qLkXqquHDvSM
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Magnus Hagander (magnus@hagander.net) wrote:
> >> That=E4s why I suggested the three value one. Default to a mode where
> >> it's automatic, which is what the majority is going to want, but have
> >> a way to explicitly turn it on.
>=20
> > This is certainly fine with me too, though it seems a bit surprising to
> > me that we couldn't just figure out what the user actually wants based
> > on what's installed/running for any given combination.
>=20
> I'd be on board with having pg_stat_statement's pg_init function do
> something to adjust the setting, if we can figure out how to do that
> in a way that's not confusing in itself.  I'm not sure though that
> the GUC engine offers a good way.

Both of the extensions are getting loaded via pg_stat_statements and
both can have pg_init functions which work together to come up with the
right answer, no?

That is- can't pg_stat_statements, when it's loaded, enable
compute_query_id if it's not already enabled, and then the pg_queryid
module simply disable it when it gets loaded in it's pg_init()?  Telling
people who are using pg_queryid to have it loaded *after*
pg_stat_statements certainly seems reasonable to me, but if folks don't
like that then maybe have a tri-state which is 'auto', 'on', and 'off',
where pg_stat_statements would set it to 'on' if it's set to 'auto', but
not do anything if it starts as 'off'.  pg_queryid would then set it to
'off' when it's loaded and it wouldn't matter if it's loaded before or
after.

Thanks,

Stephen

--uz98qLkXqquHDvSM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJghvvEAAoJEO1sijiDR2RVsYIP/iY5OLvbdWKJrABPJWQZJUlY
2gRzJ3oh69hsYspu2PIJHyqe0zLRTRJZyCKkX0Faq6vkyRTl/+L66r1wNLOcb+ZV
9BT59R2iGbHD2BAfhb2pDTSWBr0SHcGYrS4DCZNuIjM8SQyG6UxrKmQsqnR91qiU
ycXnWE+c3mHUksXe+ouN1/XE/j3NzdGTUhCCjrcqBeFSCwx0LUDqCLxWYMREaYqD
DZlAFK4tL5S2qWOeZFVutLR1Jg0u+c1ouLTl1Rab+EYo2yAkKAdavlvz8Lb7ZQPN
2nU5M8HG9pYPVQAZkCqQPR4CSz0C/8MyUGbC4knMGoKjWZCBCMGP0fDTbloUxrqQ
k2ALstUytE+GEPAMHDRoDgudeMQd7Mh6HZqkV0e20NUAHXcUP0Q3eP3ldUVTjXjd
eLQTo/9vur2da/lbi9m7WheyBYmYGM5F89ATTKaQGallGvcNe4sL3sFO8w8LkD4k
CrqoDjf1H4IvOOXu6ipWitFc1BN8rOMugIqfpsdD1jvLxelCgzAiKiuRjJc/85DD
VRTwCsNHSoXEk9GAcdcjZEUZ4+JNkFNWHQcT1/7nbgt5eXfS2PlfG0i81Hthvc+a
OTYXcvaumgz+R2zRJlAMabjIW+UU3QtL2QTf8JtcdJV8HJAe2Cm9ZeSfdKxprReq
8o+vAG9YQZrMTQFsKz5j
=0Z4r
-----END PGP SIGNATURE-----

--uz98qLkXqquHDvSM--