Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lbBWv-0004nX-Qy
	for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Apr 2021 00:24:46 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lbBWu-0006W6-BB
	for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Apr 2021 00:24:44 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <shackle@fetter.org>)
	id 1lbBWt-0006Vz-Pg
	for pgsql-hackers@lists.postgresql.org; Tue, 27 Apr 2021 00:24:44 +0000
Received: from xvm-110-146.dc2.ghst.net ([46.226.110.146] helo=fetter.org)
	by makus.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <shackle@fetter.org>)
	id 1lbBWn-0006Lm-3P
	for pgsql-hackers@postgresql.org; Tue, 27 Apr 2021 00:24:42 +0000
Received: by fetter.org (Postfix, from userid 1001)
	id A4B0740CBE; Tue, 27 Apr 2021 02:24:34 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fetter.org;
	s=default; t=1619483074;
	bh=XDrf5Waeq+YW/LDkLmMuwyi7mP2J8xFm+dGLIiARk8g=;
	h=Date:From:To:Subject:From;
	b=H4sfe/eQR8Q84Q8eMXAJ8FSj7L6jVGDuWJc3NN5Xt4S8LaNiZzBw2oknm3KXR7vKs
	 Z501/W9ekgsiIp16v3GS3+QRzUSuY+1W12UEywMGCXePgauB4lRA9QlQ9BZ9RoFp1t
	 nlpNWQdD0bgBmPouDz6g5Th5xPmcGTkdQiTksdfu4X8SmhHOfu2HreRQH+W4IPxbW3
	 b+09UxPIAVnKOrInHw9KZfufjiGJnabLsf/f+jX6YY75xHrL9vBWcYWViJbukbjJWA
	 pi1VokEtYQDISYWTWqdlBQ1TwTYOK4GJFtDs32rnq72OcmbKakXHUoNm3iV2umx68j
	 2Cp/61DsCTnjg==
Date: Tue, 27 Apr 2021 00:24:34 +0000
From: David Fetter <david@fetter.org>
To: PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT
 ...
Message-ID: <20210427002433.GB17834@fetter.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="cmJC7u66zC7hs+87"
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20210427002433.GB17834%40fetter.org>
Precedence: bulk


--cmJC7u66zC7hs+87
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Folks,

I noticed that $subject completes with already valid constraints,
please find attached a patch that fixes it. I noticed that there are
other places constraints can be validated, but didn't check whether
similar bugs exist there yet.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

--cmJC7u66zC7hs+87
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="v1-0001-tab-completion-of-ALTER-TABLE.VALIDATE-CONSTRAINT.patch"