Date: Wed, 28 Apr 2021 08:11:47 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Some doubious error messages and comments
Message-ID: <20210428131146.GC27406@telsasoft.com>
References: <20210428.173633.1525059946206239295.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210428.173633.1525059946206239295.horikyota.ntt@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210428131146.GC27406%40telsasoft.com>
Precedence: bulk

On Wed, Apr 28, 2021 at 05:36:33PM +0900, Kyotaro Horiguchi wrote:
> 0001: I found some typos in a error message and a comment.
> 
> multirangetypes.c: 1420
> > errmsg("range_intersect_agg must be called with a multirange")));
> 
> This "range_intersect_agg" looks like a typo of "multirange_..".
> 
> operatorcmds.c:303
> > * Look up a join estimator function ny name, and verify that it has the
> 
> "ny" looks like a typo of "by".

"ny name" shows up a 2nd time.

I have another "comment typos" patch - maybe someone will want to push them
together.

commit 32e979c652c68ca5e3a7f308d677058e0c08547b
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date:   Wed Apr 28 17:23:52 2021 +0900

    Fix typos
    
    ny name: 321eed5f0f7563a0cabb3d7a98132856287c1ad1
    multirange: 6df7a9698bb036610c1e8c6d375e1be38cb26d5f

diff --git a/src/backend/commands/operatorcmds.c b/src/backend/commands/operatorcmds.c
index 809043c5d1..fbd7d8d062 100644
--- a/src/backend/commands/operatorcmds.c
+++ b/src/backend/commands/operatorcmds.c
@@ -265,7 +265,7 @@ DefineOperator(List *names, List *parameters)
 }
 
 /*
- * Look up a restriction estimator function ny name, and verify that it has
+ * Look up a restriction estimator function by name, and verify that it has
  * the correct signature and we have the permissions to attach it to an
  * operator.
  */
@@ -300,7 +300,7 @@ ValidateRestrictionEstimator(List *restrictionName)
 }
 
 /*
- * Look up a join estimator function ny name, and verify that it has the
+ * Look up a join estimator function by name, and verify that it has the
  * correct signature and we have the permissions to attach it to an
  * operator.
  */
diff --git a/src/backend/utils/adt/multirangetypes.c b/src/backend/utils/adt/multirangetypes.c
index 0b81649779..2583ddeedf 100644
--- a/src/backend/utils/adt/multirangetypes.c
+++ b/src/backend/utils/adt/multirangetypes.c
@@ -1417,7 +1417,7 @@ multirange_intersect_agg_transfn(PG_FUNCTION_ARGS)
 	if (!type_is_multirange(mltrngtypoid))
 		ereport(ERROR,
 				(errcode(ERRCODE_DATATYPE_MISMATCH),
-				 errmsg("range_intersect_agg must be called with a multirange")));
+				 errmsg("multirange_intersect_agg must be called with a multirange")));
 
 	typcache = multirange_get_typcache(fcinfo, mltrngtypoid);
 

commit 8247b4034ed4c68241be9fbdec249bc967ceafd4
Author: Justin Pryzby <pryzbyj@telsasoft.com>
Date:   Tue Apr 27 07:57:50 2021 -0500

    Comment typos: extended stats a4d75c86b and 518442c7f

diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
index 9dd30370da..eb9e63f4a8 100644
--- a/src/backend/parser/parse_utilcmd.c
+++ b/src/backend/parser/parse_utilcmd.c
@@ -1943,7 +1943,7 @@ generateClonedExtStatsStmt(RangeVar *heapRel, Oid heapRelid,
 	 * simply append them after simple column references.
 	 *
 	 * XXX Some places during build/estimation treat expressions as if they
-	 * are before atttibutes, but for the CREATE command that's entirely
+	 * are before attributes, but for the CREATE command that's entirely
 	 * irrelevant.
 	 */
 	datum = SysCacheGetAttr(STATEXTOID, ht_stats,
diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index 7e11cb9d5f..5e53783ea6 100644
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -1796,7 +1796,7 @@ statext_mcv_clauselist_selectivity(PlannerInfo *root, List *clauses, int varReli
 				continue;
 
 			/*
-			 * Now we know the clause is compatible (we have either atttnums
+			 * Now we know the clause is compatible (we have either attnums
 			 * or expressions extracted from it), and was not estimated yet.
 			 */