Date: Thu, 29 Apr 2021 11:39:11 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: default_tablespace doc and partitioned rels
Message-ID: <20210429153911.GA28562@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210416210201.GK3315@telsasoft.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210429153911.GA28562%40alvherre.pgsql>
Precedence: bulk

On 2021-Apr-16, Justin Pryzby wrote:

> If this parameter is set when a partitioned table is created, the partitioned
> table's tablespace will be set to the given tablespace, and which will be the
> default tablespace for partitions create in the future, even if
> default_tablespace itself has since been changed.

Pushed with very similar wording:

+       <para>
+        If this parameter is set to a value other than the empty string
+        when a partitioned table is created, the partitioned table's
+        tablespace will be set to that value, which will be used as
+        the default tablespace for partitions created in the future,
+        even if <varname>default_tablespace</varname> has changed since then.
+       </para>

I made it a separate paragraph at the end, because I noticed that I had
added the note in an inappropriate place in the earlier commit; the
second paragraph in particular is more general than this one.  Also
looking at that one I realized that we need to talk about the value
being "not the empty string".

I hope it's clear enough now, but if you or anybody have further
suggestion on improving this, I'm listening.

Thanks

-- 
Álvaro Herrera       Valdivia, Chile
"If you have nothing to say, maybe you need just the right tool to help you
not say it."                   (New York Times, about Microsoft PowerPoint)