Date: Wed, 5 May 2021 16:53:01 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Dilip Kumar <dilipbalaut@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: .ready and .done files considered harmful
Message-ID: <20210505205301.GK20766@tamriel.snowman.net>
References: <20210504042755.ehuaoz5blcnjw5yk@alap3.anarazel.de>
 <CA+TgmobBoMqU_fwOD48e-JY69y87SKG6=POR0FODw03soaJOUA@mail.gmail.com>
 <CAFiTN-tR+3+GjP0Qeys8jwh=jz9VpP2ibhT9ubFDLmgNb1QtMg@mail.gmail.com>
 <CA+TgmoZHBb-TmwYtAzoPYu2FW_NWyLOnABNz_U-=59wTJuz4ig@mail.gmail.com>
 <20210505170601.GF20766@tamriel.snowman.net>
 <CA+Tgmoa4=k3CeGh+OX0D9+p7Nmj3ZYaeD2ahk+=n0Bz7m5d_HA@mail.gmail.com>
 <20210505201308.GI20766@tamriel.snowman.net>
 <CA+TgmoY5hS-CXQYumdoXyY0fyxXS+Sgi6odVdvu8Ri=5LkyU_g@mail.gmail.com>
 <20210505203143.3q5xfik2r6z7rbmp@alap3.anarazel.de>
 <CA+TgmoYxD6TLbEUMnyorRFdJ8EdV8z9MCOV9qLPJr_pAqwtw9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZslkzkDHtqb5gSHN"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoYxD6TLbEUMnyorRFdJ8EdV8z9MCOV9qLPJr_pAqwtw9g@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210505205301.GK20766%40tamriel.snowman.net>
Precedence: bulk


--ZslkzkDHtqb5gSHN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Robert Haas (robertmhaas@gmail.com) wrote:
> On Wed, May 5, 2021 at 4:31 PM Andres Freund <andres@anarazel.de> wrote:
> > On 2021-05-05 16:22:21 -0400, Robert Haas wrote:
> > > Huh, I had not thought about that problem. So, at the risk of getting
> > > sidetracked, what exactly are you asking for here? Let the extension
> > > pick the timeline using an algorithm of its own devising, rather than
> > > having core do it? Or what?
> >
> > Not Stephen, but to me the most reasonable way to address this is to
> > make timeline identifier wider and randomly allocated. The sequential
> > looking natures of timelines imo is actively unhelpful.
>=20
> Yeah, I always wondered why we didn't assign them randomly.

Based on what we do today regarding the info we put into .history files,
trying to figure out which is the "latest" timeline might be a bit
tricky with randomly selected timelines.  Maybe we could find a way to
solve that though.

I do note that this comment is timeline.c is, ahem, perhaps over-stating
things a bit:

 * Note: while this is somewhat heuristic, it does positively guarantee
 * that (result + 1) is not a known timeline, and therefore it should
 * be safe to assign that ID to a new timeline.

Thanks,

Stephen

--ZslkzkDHtqb5gSHN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJgkwWtAAoJEO1sijiDR2RVO1oQAJoEyXrMafurReu/xWHBKfEA
lHgcnwZgWaDcV+Saby9XnALZ6ZlZZoGJGFGB+kfuqvlG9PsGy4Bd71FIgCuxldgV
bfOlYsuXHIz1wifdHAHVW4QhoS758Ya1/dFMXMu0sSN+X90Iv1EESrtmk/nL+aS0
HEeIDg+0b1e+V/lICghJnmIjedzbjubBxCUoqeeLhagv1Sq9AV9meyMk64dnAH21
J9KxChR6ByGKjYwxxrfx0Q6iWrCPyWK4vMcuCc2mL2FgMVgu6VLkoltYWSoDZvcN
u0BkbulOlpveGfmTrKJqgjf7pFCmCuA0H5+bMQ/V3WJAfCi45z5MAC3Yp4sBaCqA
QitBHo4Tjjmj0etDI9oqOkPySq0nthC2+N0f3WLvEXHAH7Je7HpbHGwBoLl7n8yt
dPH25w5IzDV8kFuQu0HrA4JJWSDEgRrXwm0TjbBd09o+gQDMkpEchDIpIYjSDWZP
FQDAo9JSyq2nh6NfGe45M/SvRx6vM4SmHeIAgE2wynS3M6RdnYTMTHZuj96X3zWr
EIamHKoWkS6AVb4Lx0p6+VQ7gwkfUJQOY70HxF1CLmTruP8JecorFRB5R2e1laPM
kgn+vn2L/IxNgkXWEYWTT+rPr1UH6gLgBmfU7kjJi5R1b/mRKm8KW8eClvasFfwm
ZOXoYEDKCYXZjyKxC/iP
=uAp3
-----END PGP SIGNATURE-----

--ZslkzkDHtqb5gSHN--