Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leVoo-0006eW-Iw for pgsql-hackers@arkaria.postgresql.org; Thu, 06 May 2021 04:40:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1leVom-0002K2-GZ for pgsql-hackers@arkaria.postgresql.org; Thu, 06 May 2021 04:40:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leVom-0002Iy-4e for pgsql-hackers@lists.postgresql.org; Thu, 06 May 2021 04:40:56 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1leVoe-0005b0-T4 for pgsql-hackers@postgresql.org; Thu, 06 May 2021 04:40:55 +0000 Received: by mail-io1-xd2a.google.com with SMTP id p8so3692408iol.11 for ; Wed, 05 May 2021 21:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7UiU1vzJAkNrryIfv+lMSdP4j2Pg51mtmT/IDvU4nVE=; b=IdYhg6NZKssV9iS/gt4ZgDuIzA44XNVCIyCbNRh0cLpytsG/5URhJdzTB6imHBOzBO T7WE6dizYNH3cec6gPcTLf+dZE5Vin4T0i+UQOxznJGjztIiinQXzI4Eo8RSxxDI7HUM arPs96ZWR9CzFogvjs9rSJznbvXADMOD2G6X1FG1JKw9vqTiXRKFp76ElQtrR3o5PjZ3 1ALTb5oe/O+fs51pFlEABvAuFXGexOEWsNq8aRIDh5fyD5OwFW8tBXaIf1FdD5TLLVoM eoCoPmA8RfSkVEp8lESm5lGVclEZYZnLpRbdp3n87YPLg0pfi0MskYRXo9VyjmWBe00o 3dRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7UiU1vzJAkNrryIfv+lMSdP4j2Pg51mtmT/IDvU4nVE=; b=tKpZGkgSl40fuzJpbnYrmYhb7/fMzEqbcXx3o9Jvj4dTUHJLiUHo7VvvI2t2osjdJQ pl3hMonRfKqcAlag8CFhtoiKqoRz4bXaTQFmoDhB+fNkxlfImrS5x03Aqwg16CMqkXLm KrSE8MaF9uZaDqOJZoXlhKMVSTgBGJYu73A17U4PuFBQbulh4HuRZchi9cy616dNV1le sZ8ggTQ335ni1YbB/cE6qqhcI1n3tPIXwhBj0XnQXocAUjUqisFdChAsDBkAvdOJx8Yd 7PD8FU6LN/HmqAQ1hDMiMXTp5tunqNsiyLv+7z1g6iqQZ5ZoL4+I1LI8+iaHzhaHnJOq sZMw== X-Gm-Message-State: AOAM533+t1MvXRHPnP4vmL7HCiHTxhQHImoPMMK0miay0v8+zkTM94IF s12Gsw/Q/VWbiB9jWkXruT/BBzQ90SAsgw== X-Google-Smtp-Source: ABdhPJx/9My8ALWmtVulfDz8XfUXV7fi5utx/hygp5yk+r+oizJBRCkyj2KM/GaWvue0l77kXeyBBw== X-Received: by 2002:a6b:7901:: with SMTP id i1mr1659677iop.41.1620276047044; Wed, 05 May 2021 21:40:47 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id o8sm781083ils.46.2021.05.05.21.40.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 May 2021 21:40:46 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id A40348008F8; Wed, 5 May 2021 23:40:45 -0500 (CDT) Date: Wed, 5 May 2021 23:40:45 -0500 From: Justin Pryzby To: Jeff Davis Cc: pgsql-hackers@postgresql.org Subject: Re: [v15] ALTER TABLE ... SET ACCESS METHOD Message-ID: <20210506044045.GE27406@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, May 05, 2021 at 08:45:50PM -0700, Jeff Davis wrote: > The attached patch implements ALTER TABLE ... SET ACCESS METHOD. > > For simplicity, I used the normal alter table path, ATRewriteTable(), > which does not follow the stricter isolation semantics that VACUUM FULL > follows. If someone thinks that's unacceptable, please let me know. Why doees your patch say v15? It's nearly the same as my pre-existing patch, so should merge them. https://commitfest.postgresql.org/33/3020/ -- Justin