Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfMuz-0000vU-5N for pgsql-hackers@arkaria.postgresql.org; Sat, 08 May 2021 13:22:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lfMux-0002qo-M2 for pgsql-hackers@arkaria.postgresql.org; Sat, 08 May 2021 13:22:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfMux-0002qg-9Q for pgsql-hackers@lists.postgresql.org; Sat, 08 May 2021 13:22:51 +0000 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lfMuq-0000eU-AR for pgsql-hackers@lists.postgresql.org; Sat, 08 May 2021 13:22:50 +0000 Received: by mail-ot1-x32a.google.com with SMTP id u25-20020a0568302319b02902ac3d54c25eso10397428ote.1 for ; Sat, 08 May 2021 06:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=e43rAd5IGcAD0gzoeCE7P1Z4cqzn9hdDCVoEIHSQQZU=; b=Fvlk47Q++Yr8uX3jT2S8LDWh14b1h8oSMmTI8FXfyfdy0cspotA0Rejm8yZRKizZpZ T84sY3/Uy6P/jXfH5W+nx2WV7eU1E7/nHREx/XwUjdfvcNgfJAkJi4mkva7xxzw2KW/S tXyHi0pzPPJUHf018uPmxvHDufHEHcy4dhl9qlgREXJCJ5/0O/cWeZQWHHf7q0GnkXgP 0oPjr3M5pV4+Ve7pLq0OKfZ65Vmjjjvh21MsoMEblcUtXQ+O1rb8hkjSJvYMsdsfNuXZ Jybyfmg9bAUYjQ0QSVgEwXQFBuyeup9I+/WGjg9sNoJfM+ndiqXb8p6fGEjCJKtHCB11 9omA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e43rAd5IGcAD0gzoeCE7P1Z4cqzn9hdDCVoEIHSQQZU=; b=KYAJqUnmwUYt5ZPBP+0j4u9OaqVUNqhEN4NLbBCneS+3LuVrr3jWDG9CNF+WieOJht j6wpkNz6dxvVYdc4Aih5lKXNQl0ZJwris8Y4WTdmACO/05XqmZYDZYETld/u8qBK9CMh 7lBmy5CW1R9h8Cv4mqCHtmzp12LxNpMtKBAUCXuW86ctk5nvKvu2trhZjX2alPG5Z5Zt x05epYMh2oIfD8Twe55AzD7WxNNqVUKEptTQyPzym/xg3sPljbgiBTG6JU6VZt/xw4h3 AV1rr/44RxVtvbvca8tumSrefK58SRJsOml1ik5wuej569QQcvHDCZIizU5jzrV0RGUM QpOg== X-Gm-Message-State: AOAM5305D1/7SKL4e88fSogK5BK/i5S7gIO2Hk5rL4m4Hn9C6zXP8jZ/ 649WzSKTiVxF5NUi51SVCXWW2g== X-Google-Smtp-Source: ABdhPJyF8ozJUmHj5fJ+UUvLbo18q8EEKXPjzyIX9lV/AYqzJKWdJXtQO6fg2+Cm+q1pfvMGQVCSuw== X-Received: by 2002:a9d:86e:: with SMTP id 101mr12655865oty.369.1620480161568; Sat, 08 May 2021 06:22:41 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id w13sm1614625oop.0.2021.05.08.06.22.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 May 2021 06:22:41 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 050358008D1; Sat, 8 May 2021 08:22:39 -0500 (CDT) Date: Sat, 8 May 2021 08:22:39 -0500 From: Justin Pryzby To: Michael Paquier Cc: Dilip Kumar , Robert Haas , Postgres hackers , Jacob Champion Subject: Re: Small issues with CREATE TABLE COMPRESSION Message-ID: <20210508132239.GX27406@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, May 08, 2021 at 10:13:09PM +0900, Michael Paquier wrote: > + You need LZ4, if you want to support > + the compression of data with this method; see > + . I suggest to change "the compression" to "compression". I would write the whole thing like: | The LZ4 library is needed to support compression of data using that method... > + Build with LZ4 compression support. > + This allows the use of LZ4 for the > + compression of table data. remove "the" -- Justin