Date: Sat, 8 May 2021 09:06:18 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dilip Kumar <dilipbalaut@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Jacob Champion <pchampion@vmware.com>
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Message-ID: <20210508140618.GA10189@telsasoft.com>
References: <YJJz1bbvBXyzEG68@paquier.xyz>
 <CAFiTN-v-P1zAS+r0AGv148EY=hhLCQh4RAN318OWT=Hwa=WwAQ@mail.gmail.com>
 <CA+TgmoavG0eN8UdWFwjKEH9LfoYsGzpQxnhPaegnwuAp5d=PHw@mail.gmail.com>
 <YJMyr0feaqIuqJQz@paquier.xyz>
 <CAFiTN-s2Pm901O6sHy4scr6kNMgWHQ6_n7+BtKmdK+4fkYzMiQ@mail.gmail.com>
 <YJPdNeF68XpwDDki@paquier.xyz>
 <CAFiTN-sb-hA9=85Hac9J7oY9B=4DE=fPinF=oKTL-QW7eQV1Hw@mail.gmail.com>
 <YJZN5up79UvHuLWp@paquier.xyz>
 <YJaOZQDXBVySq+Cc@paquier.xyz>
 <20210508132239.GX27406@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210508132239.GX27406@telsasoft.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210508140618.GA10189%40telsasoft.com>
Precedence: bulk

| You need LZ4, if you want to support the compression of data with this method; see CREATE TABLE. 

I suggest that should reference guc-default-toast-compression instead of CREATE
TABLE, since CREATE TABLE is large and very non-specific.

Also, in at least 3 places there's extraneous trailing whitespace.
Two of these should (I think) be a blank line.

+      <xref linkend="sql-createtable"/>.$
+     </para>$
+    </listitem>$
+    $
     <listitem>$

+         compression of table data.   $
+        </para>$
+       </listitem>$
+      </varlistentry>$
+      $