Date: Tue, 11 May 2021 17:41:06 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
	Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Stephen Frost <sfrost@snowman.net>,
	Bruce Momjian <bruce@momjian.us>, Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <20210511094106.tqocsdmoefvu5lpu@nol>
References: <20210426174331.GA19401@alvherre.pgsql>
 <20210426181408.3j6kkzpxnadpwptv@alap3.anarazel.de>
 <2295572.1619461260@sss.pgh.pa.us>
 <20210426183745.4gd2s5qra6mlxfto@alap3.anarazel.de>
 <20210427062504.ofz3rgedbrl5bep2@nol>
 <YJoeXcrwe1EDmqKT@paquier.xyz>
 <20210511073539.vw4m46vvbqhiwnz5@nol>
 <4f0929bf-c690-f2be-a050-a69a47a79651@oss.nttdata.com>
 <20210511085219.knbimwnsq45cloxm@nol>
 <CABUevEy7pFmw4NeEjpjGhAOKrOaTDVqdw3Z9KshvFKPG=iy3kA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CABUevEy7pFmw4NeEjpjGhAOKrOaTDVqdw3Z9KshvFKPG=iy3kA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20210511094106.tqocsdmoefvu5lpu%40nol>
Precedence: bulk

On Tue, May 11, 2021 at 10:59:51AM +0200, Magnus Hagander wrote:
> 
> That doesn't fundamentally make it impossible, you just have to add it
> to the list of variables being copied over, wouldn't you? See
> save_backend_variables()

Yes, I agree, and that's what I meant by "explicitly handled".  The thing is
that I don't know if that's the best way to go, as it doesn't solve the "is it
actually enabled" and/or "which implementation is used".  At least the patch I
sent, although it's totally a hack, let you know if compute_query_id is enabled
or not.  I'm fine with implementing it that way, but only if there's a
consensus.